Re: [PATCH v3 04/20] sg: rework sg_poll(), minor changes

2019-08-12 Thread Douglas Gilbert
On 2019-08-12 10:23 a.m., Christoph Hellwig wrote: On Wed, Aug 07, 2019 at 01:42:36PM +0200, Douglas Gilbert wrote: Re-arrange code in sg_poll(). Rename sg_read_oxfer() to sg_rd_append(). In sg_start_req() rename rw to r0w. Plus associated changes demanded by checkpatch.pl r0w seems like a rea

Re: [PATCH v3 04/20] sg: rework sg_poll(), minor changes

2019-08-12 Thread Christoph Hellwig
On Wed, Aug 07, 2019 at 01:42:36PM +0200, Douglas Gilbert wrote: > Re-arrange code in sg_poll(). Rename sg_read_oxfer() to > sg_rd_append(). In sg_start_req() rename rw to r0w. > Plus associated changes demanded by checkpatch.pl r0w seems like a really odd variably name that doesn't help readabili