Re: [PATCH v2 12/15] lpfc: Fix rport leak.

2015-05-29 Thread James Smart
That's good to know. We have a fair amount of existing strings that are split, so I don't want to retrofit those. But, on future submits, we'll keep the string on a single line. Thanks -- james On 5/27/2015 5:32 PM, Sebastian Herbszt wrote: James Smart wrote: Sebastian, Re: more than 1 s

Re: [PATCH v2 12/15] lpfc: Fix rport leak.

2015-05-27 Thread Sebastian Herbszt
James Smart wrote: > Sebastian, > > Re: more than 1 space between a type declaration and a variable name - I > do not believe that's a hard requirement. It fully passes checkpatch. > Yes, consistent style use (aligning all variable names at same offset, > or always 1) would be good - but code h

Re: [PATCH v2 12/15] lpfc: Fix rport leak.

2015-05-26 Thread James Bottomley
On Tue, 2015-05-26 at 09:30 -0400, James Smart wrote: > Sebastian, > > Re: more than 1 space between a type declaration and a variable name - I > do not believe that's a hard requirement. It fully passes checkpatch. > Yes, consistent style use (aligning all variable names at same offset, > or a

Re: [PATCH v2 12/15] lpfc: Fix rport leak.

2015-05-26 Thread James Smart
Sebastian, Re: more than 1 space between a type declaration and a variable name - I do not believe that's a hard requirement. It fully passes checkpatch. Yes, consistent style use (aligning all variable names at same offset, or always 1) would be good - but code has been there so long with al

Re: [PATCH v2 12/15] lpfc: Fix rport leak.

2015-05-24 Thread Sebastian Herbszt
James Smart wrote: > > Fix rport leak. > > Correct locking and refcounting in tracking our rports > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_disc.h| 4 +- > drivers/scsi/lpfc/lpfc_els.c | 12 +++- > drivers/scsi/lpfc/lpfc_hbadisc.c |