Re: [PATCH 4/5] target: user: Fix sense data handling

2017-07-10 Thread Damien Le Moal
Mike, On 7/11/17 02:26, Mike Christie wrote: > On 07/10/2017 12:36 AM, Damien Le Moal wrote: >> Nicholas, Mike, >> >> On 7/7/17 15:05, Nicholas A. Bellinger wrote: >>> Everything including MNC's #1-6 and your #1-2 be pushed to >>> target-pending/for-next shortly. >>> >>> Please use this as your ba

Re: [PATCH 4/5] target: user: Fix sense data handling

2017-07-10 Thread Mike Christie
On 07/10/2017 12:36 AM, Damien Le Moal wrote: > Nicholas, Mike, > > On 7/7/17 15:05, Nicholas A. Bellinger wrote: >> Everything including MNC's #1-6 and your #1-2 be pushed to >> target-pending/for-next shortly. >> >> Please use this as your base for testing. :) > > I ran tests this morning with

Re: [PATCH 4/5] target: user: Fix sense data handling

2017-07-09 Thread Damien Le Moal
Nicholas, Mike, On 7/7/17 15:05, Nicholas A. Bellinger wrote: > Everything including MNC's #1-6 and your #1-2 be pushed to > target-pending/for-next shortly. > > Please use this as your base for testing. :) I ran tests this morning with the latest target-pending/for-next branch. I ran libzbc te

Re: [PATCH 4/5] target: user: Fix sense data handling

2017-07-07 Thread Mike Christie
On 07/06/2017 11:50 PM, Nicholas A. Bellinger wrote: > Hey MNC & Co, > > On Wed, 2017-06-28 at 12:44 -0500, Mike Christie wrote: >> On 06/28/2017 12:58 AM, Damien Le Moal wrote: >>> If the user request handler completed the request with a CHECK CONDITION >>> status, tcmu_handle_completion() copies

Re: [PATCH 4/5] target: user: Fix sense data handling

2017-07-06 Thread Damien Le Moal
On 7/7/17 15:06, Nicholas A. Bellinger wrote: >>> My apologies. I have been busy with other things and could not get to that. >>> > > Oh btw, I was talking to MNC wrt to his original patch series, and not > yours. :) Yes, I realized that after sending. Tired Friday afternoon here in Japan. My

Re: [PATCH 4/5] target: user: Fix sense data handling

2017-07-06 Thread Nicholas A. Bellinger
On Thu, 2017-07-06 at 23:05 -0700, Nicholas A. Bellinger wrote: > On Fri, 2017-07-07 at 14:14 +0900, Damien Le Moal wrote: > > Nicholas, > > > > On 7/7/17 13:50, Nicholas A. Bellinger wrote: > > > Hey MNC & Co, > > > > > > On Wed, 2017-06-28 at 12:44 -0500, Mike Christie wrote: > > >> On 06/28/20

Re: [PATCH 4/5] target: user: Fix sense data handling

2017-07-06 Thread Nicholas A. Bellinger
On Fri, 2017-07-07 at 14:14 +0900, Damien Le Moal wrote: > Nicholas, > > On 7/7/17 13:50, Nicholas A. Bellinger wrote: > > Hey MNC & Co, > > > > On Wed, 2017-06-28 at 12:44 -0500, Mike Christie wrote: > >> On 06/28/2017 12:58 AM, Damien Le Moal wrote: > >>> If the user request handler completed t

Re: [PATCH 4/5] target: user: Fix sense data handling

2017-07-06 Thread Damien Le Moal
Nicholas, On 7/7/17 13:50, Nicholas A. Bellinger wrote: > Hey MNC & Co, > > On Wed, 2017-06-28 at 12:44 -0500, Mike Christie wrote: >> On 06/28/2017 12:58 AM, Damien Le Moal wrote: >>> If the user request handler completed the request with a CHECK CONDITION >>> status, tcmu_handle_completion() co

Re: [PATCH 4/5] target: user: Fix sense data handling

2017-07-06 Thread Nicholas A. Bellinger
(Adding MNC CC') On Wed, 2017-06-28 at 14:58 +0900, Damien Le Moal wrote: > If the user request handler completed the request with a CHECK CONDITION > status, tcmu_handle_completion() copies the command entry sense data > into the session request structure sense data. However, the sense data > len

Re: [PATCH 4/5] target: user: Fix sense data handling

2017-07-06 Thread Nicholas A. Bellinger
Hey MNC & Co, On Wed, 2017-06-28 at 12:44 -0500, Mike Christie wrote: > On 06/28/2017 12:58 AM, Damien Le Moal wrote: > > If the user request handler completed the request with a CHECK CONDITION > > status, tcmu_handle_completion() copies the command entry sense data > > into the session request s

Re: [PATCH 4/5] target: user: Fix sense data handling

2017-06-28 Thread Damien Le Moal
On 6/29/17 02:44, Mike Christie wrote: > On 06/28/2017 12:58 AM, Damien Le Moal wrote: >> If the user request handler completed the request with a CHECK CONDITION >> status, tcmu_handle_completion() copies the command entry sense data >> into the session request structure sense data. However, the

Re: [PATCH 4/5] target: user: Fix sense data handling

2017-06-28 Thread Mike Christie
On 06/28/2017 12:58 AM, Damien Le Moal wrote: > If the user request handler completed the request with a CHECK CONDITION > status, tcmu_handle_completion() copies the command entry sense data > into the session request structure sense data. However, the sense data > length indicated by the field sc