Re: [PATCH 4/4] scsi: pm8001: fix pm8001_store_update_fw

2014-07-30 Thread Tomas Henzl
On 07/10/2014 03:30 PM, Tomas Henzl wrote: > On 07/10/2014 08:43 AM, Christoph Hellwig wrote: >> On Mon, Jul 07, 2014 at 05:20:01PM +0200, Tomas Henzl wrote: >>> The current implementation may mix the negative value returned >>> from pm8001_set_nvmd with with count. -(-ENOMEM) could be interpreted

Re: [PATCH 4/4] scsi: pm8001: fix pm8001_store_update_fw

2014-07-10 Thread Tomas Henzl
On 07/10/2014 08:43 AM, Christoph Hellwig wrote: > On Mon, Jul 07, 2014 at 05:20:01PM +0200, Tomas Henzl wrote: >> The current implementation may mix the negative value returned >> from pm8001_set_nvmd with with count. -(-ENOMEM) could be interpreted >> as bytes programmed, this patch fixes it. > T

Re: [PATCH 4/4] scsi: pm8001: fix pm8001_store_update_fw

2014-07-09 Thread Christoph Hellwig
On Mon, Jul 07, 2014 at 05:20:01PM +0200, Tomas Henzl wrote: > The current implementation may mix the negative value returned > from pm8001_set_nvmd with with count. -(-ENOMEM) could be interpreted > as bytes programmed, this patch fixes it. This still doesn;t look correct to me as err mixes up th