RE: [PATCH 3/5] scsi: ufs: amend interrupt configuration

2013-05-02 Thread Seungwon Jeon
On Tuesday, April 30, 2013, Subhash Jadavani wrote: > Patch looks good but one minor comment below. > > On 4/24/2013 9:36 PM, Seungwon Jeon wrote: > > It makes interrupt setting more flexible especially > > for disabling. And wrong bit mask is fixed for ver 1.0. > > [17:16] is added for mask. > >

Re: [PATCH 3/5] scsi: ufs: amend interrupt configuration

2013-05-01 Thread merez
Tested-by: Maya Erez > Patch looks good but one minor comment below. > > On 4/24/2013 9:36 PM, Seungwon Jeon wrote: >> It makes interrupt setting more flexible especially >> for disabling. And wrong bit mask is fixed for ver 1.0. >> [17:16] is added for mask. >> >> Signed-off-by: Seungwon Jeon >

Re: [PATCH 3/5] scsi: ufs: amend interrupt configuration

2013-04-30 Thread Subhash Jadavani
Patch looks good but one minor comment below. On 4/24/2013 9:36 PM, Seungwon Jeon wrote: It makes interrupt setting more flexible especially for disabling. And wrong bit mask is fixed for ver 1.0. [17:16] is added for mask. Signed-off-by: Seungwon Jeon --- drivers/scsi/ufs/ufshcd.c | 86 ++