Re: [PATCH 3/5] add sg segment limitation info to device structure

2007-10-03 Thread Greg KH
On Wed, Oct 03, 2007 at 11:19:22PM +0900, FUJITA Tomonori wrote: > On Tue, 2 Oct 2007 09:44:13 -0700 > Greg KH <[EMAIL PROTECTED]> wrote: > > > On Tue, Oct 02, 2007 at 09:25:34AM -0600, Matthew Wilcox wrote: > > > On Tue, Oct 02, 2007 at 05:23:39PM +0200, Kay Sievers wrote: > > > > Just looking at

Re: [PATCH 3/5] add sg segment limitation info to device structure

2007-10-03 Thread Jeff Garzik
FUJITA Tomonori wrote: On Tue, 2 Oct 2007 09:44:13 -0700 Greg KH <[EMAIL PROTECTED]> wrote: On Tue, Oct 02, 2007 at 09:25:34AM -0600, Matthew Wilcox wrote: On Tue, Oct 02, 2007 at 05:23:39PM +0200, Kay Sievers wrote: Just looking at the number of devices, it seems that allocating it dynamical

Re: [PATCH 3/5] add sg segment limitation info to device structure

2007-10-03 Thread FUJITA Tomonori
On Tue, 2 Oct 2007 09:44:13 -0700 Greg KH <[EMAIL PROTECTED]> wrote: > On Tue, Oct 02, 2007 at 09:25:34AM -0600, Matthew Wilcox wrote: > > On Tue, Oct 02, 2007 at 05:23:39PM +0200, Kay Sievers wrote: > > > Just looking at the number of devices, it seems that allocating it > > > dynamically would b

Re: [PATCH 3/5] add sg segment limitation info to device structure

2007-10-02 Thread Greg KH
On Tue, Oct 02, 2007 at 09:25:34AM -0600, Matthew Wilcox wrote: > On Tue, Oct 02, 2007 at 05:23:39PM +0200, Kay Sievers wrote: > > Just looking at the number of devices, it seems that allocating it > > dynamically would be the better deal. We allocate the name of every > > kobject dynamically today

Re: [PATCH 3/5] add sg segment limitation info to device structure

2007-10-02 Thread Matthew Wilcox
On Tue, Oct 02, 2007 at 05:23:39PM +0200, Kay Sievers wrote: > Just looking at the number of devices, it seems that allocating it > dynamically would be the better deal. We allocate the name of every > kobject dynamically today, so I guess it's fine to do that with the > DMA data too. But we don't

Re: [PATCH 3/5] add sg segment limitation info to device structure

2007-10-02 Thread Kay Sievers
On 10/2/07, James Bottomley <[EMAIL PROTECTED]> wrote: > On Tue, 2007-10-02 at 17:10 +0200, Kay Sievers wrote: > > On Tue, 2007-10-02 at 10:05 -0500, James Bottomley wrote: > > > On Tue, 2007-10-02 at 17:02 +0200, Kay Sievers wrote: > > > > On 10/2/07, James Bottomley <[EMAIL PROTECTED]> wrote: > >

Re: [PATCH 3/5] add sg segment limitation info to device structure

2007-10-02 Thread James Bottomley
On Tue, 2007-10-02 at 17:10 +0200, Kay Sievers wrote: > On Tue, 2007-10-02 at 10:05 -0500, James Bottomley wrote: > > On Tue, 2007-10-02 at 17:02 +0200, Kay Sievers wrote: > > > On 10/2/07, James Bottomley <[EMAIL PROTECTED]> wrote: > > > > On Mon, 2007-10-01 at 21:22 -0700, Greg KH wrote: > > > >

Re: [PATCH 3/5] add sg segment limitation info to device structure

2007-10-02 Thread Kay Sievers
On Tue, 2007-10-02 at 10:05 -0500, James Bottomley wrote: > On Tue, 2007-10-02 at 17:02 +0200, Kay Sievers wrote: > > On 10/2/07, James Bottomley <[EMAIL PROTECTED]> wrote: > > > On Mon, 2007-10-01 at 21:22 -0700, Greg KH wrote: > > > > On Mon, Oct 01, 2007 at 07:39:02PM -0600, Matthew Wilcox wrot

Re: [PATCH 3/5] add sg segment limitation info to device structure

2007-10-02 Thread James Bottomley
On Tue, 2007-10-02 at 17:02 +0200, Kay Sievers wrote: > On 10/2/07, James Bottomley <[EMAIL PROTECTED]> wrote: > > On Mon, 2007-10-01 at 21:22 -0700, Greg KH wrote: > > > On Mon, Oct 01, 2007 at 07:39:02PM -0600, Matthew Wilcox wrote: > > > > On Mon, Oct 01, 2007 at 07:36:10PM -0400, James Bottomle

Re: [PATCH 3/5] add sg segment limitation info to device structure

2007-10-02 Thread Kay Sievers
On 10/2/07, James Bottomley <[EMAIL PROTECTED]> wrote: > On Mon, 2007-10-01 at 21:22 -0700, Greg KH wrote: > > On Mon, Oct 01, 2007 at 07:39:02PM -0600, Matthew Wilcox wrote: > > > On Mon, Oct 01, 2007 at 07:36:10PM -0400, James Bottomley wrote: > > > > One possibility we could do is to add a > > >

Re: [PATCH 3/5] add sg segment limitation info to device structure

2007-10-02 Thread James Bottomley
On Mon, 2007-10-01 at 21:22 -0700, Greg KH wrote: > On Mon, Oct 01, 2007 at 07:39:02PM -0600, Matthew Wilcox wrote: > > On Mon, Oct 01, 2007 at 07:36:10PM -0400, James Bottomley wrote: > > > One possibility we could do is to add a > > > > > > struct dma_device { > > > struct device dev; > > >

Re: [PATCH 3/5] add sg segment limitation info to device structure

2007-10-01 Thread Greg KH
On Mon, Oct 01, 2007 at 07:39:02PM -0600, Matthew Wilcox wrote: > On Mon, Oct 01, 2007 at 07:36:10PM -0400, James Bottomley wrote: > > One possibility we could do is to add a > > > > struct dma_device { > > struct device dev; > > u64 dma_mask; > > u64 coherent_dma_mask; > > unsigne

Re: [PATCH 3/5] add sg segment limitation info to device structure

2007-10-01 Thread Matthew Wilcox
On Mon, Oct 01, 2007 at 07:36:10PM -0400, James Bottomley wrote: > One possibility we could do is to add a > > struct dma_device { > struct device dev; > u64 dma_mask; > u64 coherent_dma_mask; > unsigned int max_segment_size; > /* plus any other DMA parameters */ > };

Re: [PATCH 3/5] add sg segment limitation info to device structure

2007-10-01 Thread James Bottomley
On Wed, 2007-09-26 at 09:05 -0700, Greg KH wrote: > On Wed, Sep 26, 2007 at 05:58:01PM +0900, FUJITA Tomonori wrote: > > iommu code merges sg segments without considering lld's sg segment > > restrictions. iommu code can't access to the limitations because they > > are in request_queue. This patch

Re: [PATCH 3/5] add sg segment limitation info to device structure

2007-09-26 Thread FUJITA Tomonori
On Wed, 26 Sep 2007 09:05:58 -0700 Greg KH <[EMAIL PROTECTED]> wrote: > On Wed, Sep 26, 2007 at 05:58:01PM +0900, FUJITA Tomonori wrote: > > iommu code merges sg segments without considering lld's sg segment > > restrictions. iommu code can't access to the limitations because they > > are in reque

Re: [PATCH 3/5] add sg segment limitation info to device structure

2007-09-26 Thread Greg KH
On Wed, Sep 26, 2007 at 05:58:01PM +0900, FUJITA Tomonori wrote: > iommu code merges sg segments without considering lld's sg segment > restrictions. iommu code can't access to the limitations because they > are in request_queue. This patch adds max_segment_size to device > structure. seg_boundary_