Re: [PATCH 2/8] iscsi_transport: Additional parameters for net settings

2013-05-31 Thread Mike Christie
On 05/28/2013 06:36 AM, Vikas Chaudhary wrote: > > > -Original Message- > From: Mike Christie > Date: Tuesday 28 May 2013 2:19 PM > To: Vikas > Cc: "jbottom...@parallels.com" , scsi > , Lalit Chandivade > , Ravi Anand , Harish > Zunjarrao &g

Re: [PATCH 2/8] iscsi_transport: Additional parameters for net settings

2013-05-28 Thread Vikas Chaudhary
-Original Message- From: Mike Christie Date: Tuesday 28 May 2013 2:19 PM To: Vikas Cc: "jbottom...@parallels.com" , scsi , Lalit Chandivade , Ravi Anand , Harish Zunjarrao Subject: Re: [PATCH 2/8] iscsi_transport: Additional parameters for net settings >Come on man, sam

Re: [PATCH 2/8] iscsi_transport: Additional parameters for net settings

2013-05-28 Thread Mike Christie
On 05/28/2013 03:49 AM, Mike Christie wrote: > Come on man, same comments as last patches like this :) Could you use > the same names that we currently use for existing params? > > Check for the inorder ones and the ones where we use en instead of > enabled for the postfix. Also check the others.

Re: [PATCH 2/8] iscsi_transport: Additional parameters for net settings

2013-05-28 Thread Mike Christie
Come on man, same comments as last patches like this :) Could you use the same names that we currently use for existing params? Check for the inorder ones and the ones where we use en instead of enabled for the postfix. Also check the others. Also what is up with isns. If we support passing the a