Re: [PATCH 2/7] mpt3sas: Remove use of DEF_SCSI_QCMD

2014-04-02 Thread Matthew Wilcox
On Wed, Apr 02, 2014 at 03:41:15AM -0700, Christoph Hellwig wrote: > On Thu, Mar 27, 2014 at 04:40:31PM -0400, Matthew Wilcox wrote: > > Removing the host_lock from the I/O submission path gives a huge > > scalability improvement. > > This looks reasonable to me, but did you do a full audit that a

Re: [PATCH 2/7] mpt3sas: Remove use of DEF_SCSI_QCMD

2014-04-02 Thread Christoph Hellwig
On Thu, Mar 27, 2014 at 04:40:31PM -0400, Matthew Wilcox wrote: > Removing the host_lock from the I/O submission path gives a huge > scalability improvement. This looks reasonable to me, but did you do a full audit that all state is properly synchronized in the functions called from _scsih_qcmd_lc