Re: [PATCH 2/3] qla2xxx: Remove set-but-not-used variables

2016-03-31 Thread Quinn Tran
ject: Re: [PATCH 2/3] qla2xxx: Remove set-but-not-used variables >On 2016-03-31 01:25, Bart Van Assche wrote: >> Detected these variables by building the qla2xxx driver with W=1. >> Note: removing the code that sets BIT_14 is fine since that bit is >> never tested. The

Re: [PATCH 2/3] qla2xxx: Remove set-but-not-used variables

2016-03-31 Thread Bart Van Assche
On 03/31/16 08:24, Quinn Tran wrote: diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c index c1461d2..97fcbf2 100644 --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c +++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c @@ -311,13 +311,6 @@ static void tcm_qla2xxx_free_cmd(struct ql

Re: [PATCH 2/3] qla2xxx: Remove set-but-not-used variables

2016-03-31 Thread Johannes Thumshirn
On 2016-03-31 01:25, Bart Van Assche wrote: Detected these variables by building the qla2xxx driver with W=1. Note: removing the code that sets BIT_14 is fine since that bit is never tested. The output of git grep -nH -- '->cmd_flags\s*&' drivers/scsi/qla2xxx is as follows: drivers/scsi/qla2xxx/