Re: [PATCH 2/3] block: Add badblock management for gendisks

2015-11-25 Thread Jeff Moyer
"Verma, Vishal L" writes: > On Wed, 2015-11-25 at 10:37 -0500, Jeff Moyer wrote: >> "Verma, Vishal L" writes: >> >> > On Tue, 2015-11-24 at 14:14 -0500, Jeff Moyer wrote: >> > > >> > > I'm not sure whether it makes sense to continue without badblock >> > > management for the RAID code.  I was

Re: [PATCH 2/3] block: Add badblock management for gendisks

2015-11-25 Thread Verma, Vishal L
On Wed, 2015-11-25 at 10:37 -0500, Jeff Moyer wrote: > "Verma, Vishal L" writes: > > > On Tue, 2015-11-24 at 14:14 -0500, Jeff Moyer wrote: > > > > > > I'm not sure whether it makes sense to continue without badblock > > > management for the RAID code.  I was hoping Neil would comment on > > > t

Re: [PATCH 2/3] block: Add badblock management for gendisks

2015-11-25 Thread Jeff Moyer
"Verma, Vishal L" writes: > On Tue, 2015-11-24 at 14:14 -0500, Jeff Moyer wrote: >> >> I'm not sure whether it makes sense to continue without badblock >> management for the RAID code.  I was hoping Neil would comment on >> that. >> >> -Jeff > > Not sure I follow? I believe I've kept all the ba

Re: [PATCH 2/3] block: Add badblock management for gendisks

2015-11-24 Thread Dan Williams
On Tue, Nov 24, 2015 at 12:10 PM, Verma, Vishal L wrote: > On Tue, 2015-11-24 at 14:14 -0500, Jeff Moyer wrote: >> >> I'm not sure whether it makes sense to continue without badblock >> management for the RAID code. I was hoping Neil would comment on >> that. >> >> -Jeff > > Not sure I follow? I

Re: [PATCH 2/3] block: Add badblock management for gendisks

2015-11-24 Thread Verma, Vishal L
On Tue, 2015-11-24 at 14:14 -0500, Jeff Moyer wrote: > > I'm not sure whether it makes sense to continue without badblock > management for the RAID code.  I was hoping Neil would comment on > that. > > -Jeff Not sure I follow? I believe I've kept all the badblocks functionality RAID already had.

Re: [PATCH 2/3] block: Add badblock management for gendisks

2015-11-24 Thread Jeff Moyer
"Verma, Vishal L" writes: > On Tue, 2015-11-24 at 10:34 -0500, Jeff Moyer wrote: >> Vishal Verma writes: >> >> > NVDIMM devices, which can behave more like DRAM rather than block >> > devices, may develop bad cache lines, or 'poison'. A block device >> > exposed by the pmem driver can then cons

Re: [PATCH 2/3] block: Add badblock management for gendisks

2015-11-24 Thread Verma, Vishal L
On Tue, 2015-11-24 at 10:34 -0500, Jeff Moyer wrote: > Vishal Verma writes: > > > NVDIMM devices, which can behave more like DRAM rather than block > > devices, may develop bad cache lines, or 'poison'. A block device > > exposed by the pmem driver can then consume poison via a read (or > > write

Re: [PATCH 2/3] block: Add badblock management for gendisks

2015-11-24 Thread Jeff Moyer
Vishal Verma writes: > NVDIMM devices, which can behave more like DRAM rather than block > devices, may develop bad cache lines, or 'poison'. A block device > exposed by the pmem driver can then consume poison via a read (or > write), and cause a machine check. On platforms without machine > chec