Re: [PATCH 19/21] advansys: Remove a couple of uses of bus_to_virt

2007-10-03 Thread Jeff Garzik
Matthew Wilcox wrote: On Wed, Oct 03, 2007 at 10:28:31AM -0400, Jeff Garzik wrote: Matthew Wilcox wrote: On Tue, Oct 02, 2007 at 10:13:07PM -0400, Jeff Garzik wrote: check dma_map_single for error It's on the todo list. Since so many other drivers don't check dma_map_single for error, I feel

Re: [PATCH 19/21] advansys: Remove a couple of uses of bus_to_virt

2007-10-03 Thread Matthew Wilcox
On Wed, Oct 03, 2007 at 10:28:31AM -0400, Jeff Garzik wrote: > Matthew Wilcox wrote: > >On Tue, Oct 02, 2007 at 10:13:07PM -0400, Jeff Garzik wrote: > >>check dma_map_single for error > > > >It's on the todo list. Since so many other drivers don't check > >dma_map_single for error, I feel comforta

Re: [PATCH 19/21] advansys: Remove a couple of uses of bus_to_virt

2007-10-03 Thread Jeff Garzik
Matthew Wilcox wrote: On Tue, Oct 02, 2007 at 10:13:07PM -0400, Jeff Garzik wrote: check dma_map_single for error It's on the todo list. Since so many other drivers don't check dma_map_single for error, I feel comfortable with leaving it for later. The issue became more urgent with x86-64 a

Re: [PATCH 19/21] advansys: Remove a couple of uses of bus_to_virt

2007-10-03 Thread Matthew Wilcox
On Tue, Oct 02, 2007 at 10:13:07PM -0400, Jeff Garzik wrote: > check dma_map_single for error It's on the todo list. Since so many other drivers don't check dma_map_single for error, I feel comfortable with leaving it for later. -- Intel are signing my paycheques ... these opinions are still mi

Re: [PATCH 19/21] advansys: Remove a couple of uses of bus_to_virt

2007-10-02 Thread Jeff Garzik
Matthew Wilcox wrote: Replace ASC_VADDR_TO_U32 and ASC_U32_TO_VADDR with an auto-expanding array that maps pointers to 32-bit IDs and back. One of the uses of ASC_VADDR_TO_U32 was in error; it should have been using ADV_VADDR_TO_U32. Also replace the use of virt_to_bus when setting the sense_ad