Re: [PATCH 12/25] scsi: hisi_sas: add v1 HW initialisation code

2015-10-13 Thread Arnd Bergmann
On Tuesday 13 October 2015 13:44:26 John Garry wrote: > Hello, > > Just to be clear, are you saying that you would prefer hisi_sas_probe() > and struct hisi_sas_driver to be relocated to hisi_sas_v1_hw.c? Correct. > I wanted to keep hisi_sas_v1_hw.c containing only code which accesses HW. > >

Re: [PATCH 12/25] scsi: hisi_sas: add v1 HW initialisation code

2015-10-13 Thread John Garry
On 12/10/2015 19:46, Arnd Bergmann wrote: On Monday 12 October 2015 23:20:24 John Garry wrote: @@ -387,6 +392,21 @@ static int hisi_sas_probe(struct platform_device *pdev) } hisi_sas_init_add(hisi_hba); + + rc = hw_init_v1_hw(hisi_hba); + if (rc) + go

Re: [PATCH 12/25] scsi: hisi_sas: add v1 HW initialisation code

2015-10-12 Thread Arnd Bergmann
On Monday 12 October 2015 23:20:24 John Garry wrote: > @@ -387,6 +392,21 @@ static int hisi_sas_probe(struct platform_device *pdev) > } > > hisi_sas_init_add(hisi_hba); > + > + rc = hw_init_v1_hw(hisi_hba); > + if (rc) > + goto err_out_ha; > + > + r