Re: [PATCH 1/9] qla2xxx: Move cmd search out of qla during ABTS

2016-12-20 Thread h...@infradead.org
On Mon, Dec 19, 2016 at 04:29:57PM +, Bart Van Assche wrote: > The SCSI Architecture Manual (SAM-6) specifies that the SCSI transport > protocol defines whether the scope of the ABORT TASK task management > function is I_T_L or I_T. In the Fibre Channel Protocol for SCSI (FCP) > document I read

Re: [PATCH 1/9] qla2xxx: Move cmd search out of qla during ABTS

2016-12-19 Thread Bart Van Assche
On Mon, 2016-12-19 at 07:59 -0800, h...@infradead.org wrote: > On Mon, Dec 19, 2016 at 03:33:27PM +, Bart Van Assche wrote: > > Please consider removing the sess_cmd_list loop. Any lookups in > > sess_cmd_list should be performed by the target core and not by a > > target driver. Are you aware

Re: [PATCH 1/9] qla2xxx: Move cmd search out of qla during ABTS

2016-12-19 Thread h...@infradead.org
On Mon, Dec 19, 2016 at 03:33:27PM +, Bart Van Assche wrote: > Please consider removing the sess_cmd_list loop. Any lookups in > sess_cmd_list should be performed by the target core and not by a > target driver. Are you aware that core_tmr_abort_task() performs a very > similar lookup to the on

Re: [PATCH 1/9] qla2xxx: Move cmd search out of qla during ABTS

2016-12-19 Thread Bart Van Assche
On Sun, 2016-12-18 at 01:02 -0800, Himanshu Madhani wrote: > diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c > b/drivers/scsi/qla2xxx/tcm_qla2xxx.c > index 6643f6f..9275f36 100644 > --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c > +++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c > @@ -567,6 +567,30 @@ static in