Re: [PATCH 1/3] myrb: Add Mylex RAID controller (block interface)

2018-10-17 Thread Christoph Hellwig
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index 99d366cb0e9f..1efbd175411a 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -922,10 +922,12 @@ > #define PCI_DEVICE_ID_PICOPOWER_PT86C523BBP 0x8002 > > #define PCI_VENDOR_ID_MYLEX 0x106

Re: [PATCH 1/3] myrb: Add Mylex RAID controller (block interface)

2018-10-10 Thread Christoph Hellwig
> +static void myrb_monitor(struct work_struct *work); > +static inline void DAC960_P_To_PD_TranslateDeviceState(void *DeviceState); Can you please use normal kernel function names and a normal prefix? Also there seems to be no good reason to need a forward declaration for this function. > +stat