Re: [PATCH 1/2] qla2xxx: Fix a recently introduced memory leak

2017-02-06 Thread Martin K. Petersen
> "Bart" == Bart Van Assche writes: Hi Bart, Bart> Since there is now a resolution for patch 2: have you already Bart> decided when to submit these patches upstream? I queued it in scsi-fixes last week: commit 2780f3c8f0233de90b6b47a23fc422b7780c5436 Author: Mauricio Faria de Oliveira

Re: [PATCH 1/2] qla2xxx: Fix a recently introduced memory leak

2017-02-03 Thread Bart Van Assche
On Wed, 2017-01-25 at 18:28 -0500, Martin K. Petersen wrote: > > > > > > "Bart" == Bart Van Assche writes: > > Bart> qla2x00_probe_one() allocates IRQs before it initializes rsp_q_map > Bart> so IRQs must be freed even if rsp_q_map allocation did not occur. > Bart> This was detected by kmemleak.

Re: [PATCH 1/2] qla2xxx: Fix a recently introduced memory leak

2017-01-29 Thread Bart Van Assche
On Sun, 2017-01-29 at 10:07 +0100, h...@lst.de wrote: > Hi Bart, > > thanks for the analysis. I think the main issue here is that we shouldn't > try to assign affinity masks if there are not affinity vectors left to > assign. > > Does the patch below fix the issue for you? > > diff --git a/driv

Re: [PATCH 1/2] qla2xxx: Fix a recently introduced memory leak

2017-01-29 Thread h...@lst.de
Hi Bart, thanks for the analysis. I think the main issue here is that we shouldn't try to assign affinity masks if there are not affinity vectors left to assign. Does the patch below fix the issue for you? diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index 50c5003..96c0713 100644 --- a/dr

Re: [PATCH 1/2] qla2xxx: Fix a recently introduced memory leak

2017-01-28 Thread Bart Van Assche
On Thu, 2017-01-26 at 15:36 +0100, h...@lst.de wrote: > On Wed, Jan 25, 2017 at 03:47:20PM +, Bart Van Assche wrote: > > = > > BUG kmalloc-16 (Not tainted): Redzone overwritten > > --

Re: [PATCH 1/2] qla2xxx: Fix a recently introduced memory leak

2017-01-26 Thread h...@lst.de
On Wed, Jan 25, 2017 at 03:47:20PM +, Bart Van Assche wrote: > = > BUG kmalloc-16 (Not tainted): Redzone overwritten > - > > Disabling lock de

Re: [PATCH 1/2] qla2xxx: Fix a recently introduced memory leak

2017-01-25 Thread Martin K. Petersen
> "Bart" == Bart Van Assche writes: Bart> qla2x00_probe_one() allocates IRQs before it initializes rsp_q_map Bart> so IRQs must be freed even if rsp_q_map allocation did not occur. Bart> This was detected by kmemleak. I queued this one yesterday but was waiting for a resolution on patch 2...

Re: [PATCH 1/2] qla2xxx: Fix a recently introduced memory leak

2017-01-25 Thread Bart Van Assche
On Mon, 2017-01-23 at 08:34 -0800, Bart Van Assche wrote: > qla2x00_probe_one() allocates IRQs before it initializes rsp_q_map > so IRQs must be freed even if rsp_q_map allocation did not occur. > This was detected by kmemleak. > > Fixes: 4fa183455988 ("scsi: qla2xxx: Utilize > pci_alloc_irq_vect

Re: [PATCH 1/2] qla2xxx: Fix a recently introduced memory leak

2017-01-24 Thread Johannes Thumshirn
On Mon, Jan 23, 2017 at 08:34:45AM -0800, Bart Van Assche wrote: > qla2x00_probe_one() allocates IRQs before it initializes rsp_q_map > so IRQs must be freed even if rsp_q_map allocation did not occur. > This was detected by kmemleak. > > Fixes: 4fa183455988 ("scsi: qla2xxx: Utilize > pci_alloc_i

Re: [PATCH 1/2] qla2xxx: Fix a recently introduced memory leak

2017-01-23 Thread Madhani, Himanshu
On 1/23/17, 8:34 AM, "Bart Van Assche" wrote: >qla2x00_probe_one() allocates IRQs before it initializes rsp_q_map >so IRQs must be freed even if rsp_q_map allocation did not occur. >This was detected by kmemleak. > >Fixes: 4fa183455988 ("scsi: qla2xxx: Utilize >pci_alloc_irq_vectors/pci_free_ir

Re: [PATCH 1/2] qla2xxx: Fix a recently introduced memory leak

2017-01-23 Thread Christoph Hellwig
Thanks Bart, this looks good to me. Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html