Re: [PATCH 1/2] cxlflash: Base superpipe support

2015-07-11 Thread Matthew R. Ochs
Hi Brian, Thanks for reviewing. Comments inline below. -matt On Jul 10, 2015, at 2:49 PM, Brian King wrote: > On 06/19/2015 05:37 PM, Matthew R. Ochs wrote: >> >> cfg->init_state = INIT_STATE_NONE; >> cfg->dev = pdev; >> +cfg->last_lun_index[0] = 0; >> +cfg->last_lun_index[1]

Re: [PATCH 1/2] cxlflash: Base superpipe support

2015-07-10 Thread Brian King
On 06/19/2015 05:37 PM, Matthew R. Ochs wrote: > diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c > index 76a7286..2773177 100644 > --- a/drivers/scsi/cxlflash/main.c > +++ b/drivers/scsi/cxlflash/main.c > @@ -679,10 +679,13 @@ static struct scsi_host_template driver_templat

Re: [PATCH 1/2] cxlflash: Base superpipe support

2015-07-02 Thread Michael Neuling
On Thu, 2015-07-02 at 17:00 +1000, Michael Neuling wrote: > > +struct dk_cxlflash_attach { > > + struct dk_cxlflash_hdr hdr; /* Common fields */ > > + __u64 num_interrupts; /* Requested number of interrupts */ > > + __u64 context_id; /* Returned context */ > > Mat

Re: [PATCH 1/2] cxlflash: Base superpipe support

2015-07-02 Thread Matthew R. Ochs
Mikey, Thanks for reviewing. Responses are inline below. -matt On Jul 2, 2015, at 1:39 AM, Michael Neuling wrote: > On Fri, 2015-06-19 at 17:37 -0500, Matthew R. Ochs wrote: >> >> --- a/drivers/scsi/cxlflash/common.h >> +++ b/drivers/scsi/cxlflash/common.h >> @@ -103,6 +103,14 @@ struct cxlfla

Re: [PATCH 1/2] cxlflash: Base superpipe support

2015-07-02 Thread Michael Neuling
> +struct dk_cxlflash_attach { > + struct dk_cxlflash_hdr hdr; /* Common fields */ > + __u64 num_interrupts; /* Requested number of interrupts */ > + __u64 context_id; /* Returned context */ Matt, These ioctls seem to take a context id. Why isn't that assu

Re: [PATCH 1/2] cxlflash: Base superpipe support

2015-07-01 Thread Michael Neuling
On Fri, 2015-06-19 at 17:37 -0500, Matthew R. Ochs wrote: > Add superpipe supporting infrastructure to device driver for the IBM CXL > Flash adapter. This patch allows userspace applications to take advantage > of the accelerated I/O features that this adapter provides and bypass the > traditional