Re: [PATCH 06/12] scsi_debug: re-order file scope declarations

2016-04-26 Thread Bart Van Assche
On 04/25/2016 09:16 AM, Douglas Gilbert wrote: +static unsigned int scsi_debug_lbp(void) +{ + return ((0 == sdebug_fake_rw) && + (sdebug_lbpu | sdebug_lbpws | sdebug_lbpws10)); +} Same comment here as for a previous patch: please do not introduce superfluous parentheses and

Re: [PATCH 06/12] scsi_debug: re-order file scope declarations

2016-04-25 Thread Hannes Reinecke
On 04/25/2016 06:16 PM, Douglas Gilbert wrote: > Group most defines together first; followed by struct definitions > and then table and variable definitions. Normalize all function > headers. > > Signed-off-by: Douglas Gilbert > --- > drivers/scsi/scsi_debug.c | 314 > ++