Re: [PATCH 05/22] scsi: Use sdev as argument for sense code printing

2014-09-01 Thread Hannes Reinecke
On 08/31/2014 11:55 PM, Christoph Hellwig wrote: >> -scsi_extd_sense_format(unsigned char asc, unsigned char ascq) { >> +scsi_extd_sense_format(unsigned char asc, unsigned char ascq, >> + const char **fmt) { > > please move the opening brace to a new line per normal Linux style.

Re: [PATCH 05/22] scsi: Use sdev as argument for sense code printing

2014-08-31 Thread Christoph Hellwig
> -scsi_extd_sense_format(unsigned char asc, unsigned char ascq) { > +scsi_extd_sense_format(unsigned char asc, unsigned char ascq, > +const char **fmt) { please move the opening brace to a new line per normal Linux style. Otherwise looks good, Reviewed-by: Christoph Hellwig