Re: [PATCH 04/12] IB/srp: Fix connection state tracking

2015-05-05 Thread Doug Ledford
On Tue, 2015-05-05 at 17:27 +0200, Bart Van Assche wrote: > On 05/05/15 17:10, Doug Ledford wrote: > > On Tue, 2015-05-05 at 16:26 +0200, Bart Van Assche wrote: > >> On 05/05/15 16:10, Doug Ledford wrote: > >>> However, while looking through the driver to research this, I noticed > >>> something el

Re: [PATCH 04/12] IB/srp: Fix connection state tracking

2015-05-05 Thread Bart Van Assche
On 04/30/15 18:08, Doug Ledford wrote: On Thu, 2015-04-30 at 10:58 +0200, Bart Van Assche wrote: @@ -2367,7 +2368,7 @@ static int srp_cm_handler(struct ib_cm_id *cm_id, struct ib_cm_event *event) case IB_CM_DREQ_RECEIVED: shost_printk(KERN_WARNING, target->scsi_host,

Re: [PATCH 04/12] IB/srp: Fix connection state tracking

2015-04-30 Thread Sagi Grimberg
On 4/30/2015 2:25 PM, Bart Van Assche wrote: On 04/30/15 11:51, Sagi Grimberg wrote: On 4/30/2015 11:58 AM, Bart Van Assche wrote: -srp_change_conn_state(target, false); +ch->connected = false; Shouldn't this be protected by the channel lock (like the target)? On all CPU arc