Re: [PATCH 01/16] scsi_dh_alua: Improve error handling

2014-03-07 Thread Jeremy Linton
On 3/7/2014 1:12 AM, Hannes Reinecke wrote: > Can you file a bug with bugzilla.novell.com and assign it to me? Thanks, its bug 867371 https://bugzilla.novell.com/show_bug.cgi?id=867371. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

Re: [PATCH 01/16] scsi_dh_alua: Improve error handling

2014-03-06 Thread Hannes Reinecke
On 03/07/2014 12:43 AM, Jeremy Linton wrote: > On 1/31/2014 3:29 AM, Hannes Reinecke wrote: >> Improve error handling and use standard logging functions >> instead of hand-crafted ones. >> >> @@ -182,11 +185,13 @@ static unsigned submit_rtpg(struct scsi_device *sdev, >> struct alua_dh_data *h, >>

Re: [PATCH 01/16] scsi_dh_alua: Improve error handling

2014-03-06 Thread Jeremy Linton
On 1/31/2014 3:29 AM, Hannes Reinecke wrote: > Improve error handling and use standard logging functions > instead of hand-crafted ones. > > @@ -182,11 +185,13 @@ static unsigned submit_rtpg(struct scsi_device *sdev, > struct alua_dh_data *h, > bool rtpg_ext_hdr_req)

Re: [PATCH 01/16] scsi_dh_alua: Improve error handling

2014-02-14 Thread Hannes Reinecke
On 02/14/2014 12:16 PM, Bart Van Assche wrote: > On 01/31/14 10:29, Hannes Reinecke wrote: >> - * alua_stpg - Evaluate SET TARGET GROUP STATES >> + * stpg_endio - Evaluate SET TARGET GROUP STATES > > Great that you are fixing the function header of stpg_endio(). But > please consider to use here t

Re: [PATCH 01/16] scsi_dh_alua: Improve error handling

2014-02-14 Thread Bart Van Assche
On 01/31/14 10:29, Hannes Reinecke wrote: > - * alua_stpg - Evaluate SET TARGET GROUP STATES > + * stpg_endio - Evaluate SET TARGET GROUP STATES Great that you are fixing the function header of stpg_endio(). But please consider to use here the official terminology from SPC ("SET TARGET PORT GROUPS