Re: [PATCH 01/10] scsi: Use real functions for logging

2014-11-11 Thread Hannes Reinecke
On 11/11/2014 06:38 PM, Elliott, Robert (Server Storage) wrote: > > >> -Original Message- >> From: Hannes Reinecke [mailto:h...@suse.de] >> Sent: Tuesday, 04 November, 2014 2:07 AM > ... >> diff --git a/drivers/scsi/scsi_logging.c >> b/drivers/scsi/scsi_logging.c > ... >> @@ -0,0 +1,119 @

RE: [PATCH 01/10] scsi: Use real functions for logging

2014-11-11 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Tuesday, 04 November, 2014 2:07 AM ... > diff --git a/drivers/scsi/scsi_logging.c > b/drivers/scsi/scsi_logging.c ... > @@ -0,0 +1,119 @@ > +/* > + * scsi_logging.c > + * > + * Copyright (C) 2014 SUSE Linux Product

Re: [PATCH 01/10] scsi: Use real functions for logging

2014-11-04 Thread Hannes Reinecke
On 11/04/2014 02:58 PM, Christoph Hellwig wrote: > On Tue, Nov 04, 2014 at 09:06:40AM +0100, Hannes Reinecke wrote: >> Implement a per-cpu buffer for formatting messages, >> and add real functions for scmd_printk and sdev_prefix_printk >> using that buffer and use dev_printk() to print out things.

Re: [PATCH 01/10] scsi: Use real functions for logging

2014-11-04 Thread Christoph Hellwig
On Tue, Nov 04, 2014 at 09:06:40AM +0100, Hannes Reinecke wrote: > Implement a per-cpu buffer for formatting messages, > and add real functions for scmd_printk and sdev_prefix_printk > using that buffer and use dev_printk() to print out things. > And make sdev_printk() a wrapper for sdev_prefix_pri