Re: [PATCH 0/4] scsi: fixup dma_set_mask_and_coherent() calls

2019-02-18 Thread John Garry
On 18/02/2019 07:21, Hannes Reinecke wrote: On 2/15/19 10:16 AM, John Garry wrote: On 15/02/2019 08:08, Christoph Hellwig wrote: On Fri, Feb 15, 2019 at 08:43:55AM +0100, Christoph Hellwig wrote: On Fri, Feb 15, 2019 at 07:55:39AM +0100, Hannes Reinecke wrote: Yeah, there is a few more. And

Re: [PATCH 0/4] scsi: fixup dma_set_mask_and_coherent() calls

2019-02-17 Thread Hannes Reinecke
On 2/15/19 10:16 AM, John Garry wrote: On 15/02/2019 08:08, Christoph Hellwig wrote: On Fri, Feb 15, 2019 at 08:43:55AM +0100, Christoph Hellwig wrote: On Fri, Feb 15, 2019 at 07:55:39AM +0100, Hannes Reinecke wrote: Yeah, there is a few more.  And the sad part is as of a few kernel release ag

Re: [PATCH 0/4] scsi: fixup dma_set_mask_and_coherent() calls

2019-02-15 Thread John Garry
On 15/02/2019 08:08, Christoph Hellwig wrote: On Fri, Feb 15, 2019 at 08:43:55AM +0100, Christoph Hellwig wrote: On Fri, Feb 15, 2019 at 07:55:39AM +0100, Hannes Reinecke wrote: Yeah, there is a few more. And the sad part is as of a few kernel release ago we shouldn't even need the fallback 32

Re: [PATCH 0/4] scsi: fixup dma_set_mask_and_coherent() calls

2019-02-15 Thread Christoph Hellwig
On Fri, Feb 15, 2019 at 08:43:55AM +0100, Christoph Hellwig wrote: > On Fri, Feb 15, 2019 at 07:55:39AM +0100, Hannes Reinecke wrote: > >> Yeah, there is a few more. And the sad part is as of a few kernel > >> release ago we shouldn't even need the fallback 32-bit dma mask > >> anymore - we've cle

Re: [PATCH 0/4] scsi: fixup dma_set_mask_and_coherent() calls

2019-02-14 Thread Christoph Hellwig
On Fri, Feb 15, 2019 at 07:55:39AM +0100, Hannes Reinecke wrote: >> Yeah, there is a few more. And the sad part is as of a few kernel >> release ago we shouldn't even need the fallback 32-bit dma mask >> anymore - we've cleaned up all the mess that required it. >> > Care to elaborate? > Can you po

Re: [PATCH 0/4] scsi: fixup dma_set_mask_and_coherent() calls

2019-02-14 Thread Hannes Reinecke
On 2/14/19 6:31 PM, Christoph Hellwig wrote: On Thu, Feb 14, 2019 at 09:29:05AM +, John Garry wrote: On 13/02/2019 18:51, Ewan D. Milne wrote: On Wed, 2019-02-13 at 12:42 +0100, Hannes Reinecke wrote: The recent patchset to use dma_set_mask_and_coherent() introduced a regression where a ca

Re: [PATCH 0/4] scsi: fixup dma_set_mask_and_coherent() calls

2019-02-14 Thread Christoph Hellwig
On Thu, Feb 14, 2019 at 09:29:05AM +, John Garry wrote: > On 13/02/2019 18:51, Ewan D. Milne wrote: >> On Wed, 2019-02-13 at 12:42 +0100, Hannes Reinecke wrote: >>> The recent patchset to use dma_set_mask_and_coherent() introduced >>> a regression where a call to set a 64-bit DMA mask was follo

Re: [PATCH 0/4] scsi: fixup dma_set_mask_and_coherent() calls

2019-02-14 Thread John Garry
On 13/02/2019 18:51, Ewan D. Milne wrote: On Wed, 2019-02-13 at 12:42 +0100, Hannes Reinecke wrote: The recent patchset to use dma_set_mask_and_coherent() introduced a regression where a call to set a 64-bit DMA mask was followed by a call to set a 32-bit DMA mask, leading to I/O errors and data

Re: [PATCH 0/4] scsi: fixup dma_set_mask_and_coherent() calls

2019-02-13 Thread Ewan D. Milne
On Wed, 2019-02-13 at 12:42 +0100, Hannes Reinecke wrote: > The recent patchset to use dma_set_mask_and_coherent() introduced > a regression where a call to set a 64-bit DMA mask was followed > by a call to set a 32-bit DMA mask, leading to I/O errors and > data corruption. > > Patchset is based o