Re: [PATCH 0/2] Fix SCSI & USB Storage CHECK CONDITION handling

2019-09-27 Thread Finn Thain
[snipped selective measurements of word usage] On Fri, 27 Sep 2019, Alan Stern wrote: > > So I guess this was never defined precisely. > The O.E.D. defines these terms: residual a. [...] n. 1. a quantity remaining after other things have been subtracted

Re: [PATCH 0/2] Fix SCSI & USB Storage CHECK CONDITION handling

2019-09-27 Thread Damien Le Moal
On 2019/09/27 9:34, Alan Stern wrote: > On Fri, 27 Sep 2019, Damien Le Moal wrote: > >> On 2019/09/26 16:57, Alan Stern wrote: >>> On Fri, 27 Sep 2019, Damien Le Moal wrote: >>> If a non-passthrough command is terminated with a CHECK CONDITION, the scsi error recovery code reuses the fai

Re: [PATCH 0/2] Fix SCSI & USB Storage CHECK CONDITION handling

2019-09-27 Thread Alan Stern
On Fri, 27 Sep 2019, Damien Le Moal wrote: > On 2019/09/26 16:57, Alan Stern wrote: > > On Fri, 27 Sep 2019, Damien Le Moal wrote: > > > >> If a non-passthrough command is terminated with a CHECK CONDITION, the > >> scsi error recovery code reuses the failed command scsi_cmnd structure > >> to pr

Re: [PATCH 0/2] Fix SCSI & USB Storage CHECK CONDITION handling

2019-09-27 Thread Alan Stern
On Thu, 26 Sep 2019, Douglas Gilbert wrote: > On 2019-09-26 7:57 p.m., Alan Stern wrote: > > PS: The correct term is "residue", not "residual". I know that the > > code sometimes uses the wrong word. > > Digging into my T10 document archive I found this cam3r03.pdf : > >− cam_resid; >

Re: [PATCH 0/2] Fix SCSI & USB Storage CHECK CONDITION handling

2019-09-26 Thread Douglas Gilbert
On 2019-09-26 7:57 p.m., Alan Stern wrote: On Fri, 27 Sep 2019, Damien Le Moal wrote: If a non-passthrough command is terminated with a CHECK CONDITION, the scsi error recovery code reuses the failed command scsi_cmnd structure to process error recovery request sense. To preserve information re

Re: [PATCH 0/2] Fix SCSI & USB Storage CHECK CONDITION handling

2019-09-26 Thread Damien Le Moal
On 2019/09/26 16:57, Alan Stern wrote: > On Fri, 27 Sep 2019, Damien Le Moal wrote: > >> If a non-passthrough command is terminated with a CHECK CONDITION, the >> scsi error recovery code reuses the failed command scsi_cmnd structure >> to process error recovery request sense. To preserve informat

Re: [PATCH 0/2] Fix SCSI & USB Storage CHECK CONDITION handling

2019-09-26 Thread Alan Stern
On Fri, 27 Sep 2019, Damien Le Moal wrote: > If a non-passthrough command is terminated with a CHECK CONDITION, the > scsi error recovery code reuses the failed command scsi_cmnd structure > to process error recovery request sense. To preserve information > regarding the failed command, the functi