Re: [PATCH-v2 03/17] target/sbc: Add DIF setup in sbc_check_prot + sbc_parse_cdb

2014-01-22 Thread Nicholas A. Bellinger
On Wed, 2014-01-22 at 20:00 +0200, Sagi Grimberg wrote: > On 1/22/2014 12:48 AM, Nicholas A. Bellinger wrote: > > + cmd->prot_handover = PROT_SEPERATED; > >> I know that we are not planning to support interleaved mode at the > >> moment, But I think > >> that the protection handover type is the b

Re: [PATCH-v2 03/17] target/sbc: Add DIF setup in sbc_check_prot + sbc_parse_cdb

2014-01-22 Thread Sagi Grimberg
On 1/22/2014 12:48 AM, Nicholas A. Bellinger wrote: + cmd->prot_handover = PROT_SEPERATED; I know that we are not planning to support interleaved mode at the moment, But I think that the protection handover type is the backstore preference and should be taken from se_dev. But it is not tha

Re: [PATCH-v2 03/17] target/sbc: Add DIF setup in sbc_check_prot + sbc_parse_cdb

2014-01-21 Thread Nicholas A. Bellinger
On Sun, 2014-01-19 at 13:43 +0200, Sagi Grimberg wrote: > On 1/19/2014 4:44 AM, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > This patch adds sbc_check_prot() for performing various DIF > > related CDB sanity checks, along with setting cmd->prot_type > > once sanity checks have

Re: [PATCH-v2 03/17] target/sbc: Add DIF setup in sbc_check_prot + sbc_parse_cdb

2014-01-19 Thread Sagi Grimberg
On 1/19/2014 4:44 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger This patch adds sbc_check_prot() for performing various DIF related CDB sanity checks, along with setting cmd->prot_type once sanity checks have passed. Also, add calls in sbc_parse_cdb() for READ_[10,12,16] + WRITE_[1