Re: [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-06-11 Thread Michael S. Tsirkin
On Tue, Jun 10, 2014 at 02:20:28PM -0700, Nicholas A. Bellinger wrote: > On Tue, 2014-06-10 at 13:56 -0700, Linus Torvalds wrote: > > On Tue, Jun 10, 2014 at 1:25 PM, Nicholas A. Bellinger > > wrote: > > > > > > That would work, or I can simply include a pointer to Stephen's patch in > > > the tar

Re: [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-06-10 Thread Nicholas A. Bellinger
On Tue, 2014-06-10 at 13:56 -0700, Linus Torvalds wrote: > On Tue, Jun 10, 2014 at 1:25 PM, Nicholas A. Bellinger > wrote: > > > > That would work, or I can simply include a pointer to Stephen's patch in > > the target-pending PULL request after the vhost API changes are merged > > and Linus can a

Re: [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-06-10 Thread Linus Torvalds
On Tue, Jun 10, 2014 at 1:25 PM, Nicholas A. Bellinger wrote: > > That would work, or I can simply include a pointer to Stephen's patch in > the target-pending PULL request after the vhost API changes are merged > and Linus can apply himself.. Yes. That way I'll include it in the merge, and every

Re: [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-06-10 Thread Nicholas A. Bellinger
On Tue, 2014-06-10 at 13:09 -0700, James Bottomley wrote: > On Tue, 2014-06-10 at 12:57 -0700, Nicholas A. Bellinger wrote: > > On Tue, 2014-06-10 at 21:45 +0300, Michael S. Tsirkin wrote: > > > On Tue, Jun 10, 2014 at 10:39:17AM -0700, Nicholas A. Bellinger wrote: > > > > On Tue, 2014-06-10 at 16:

Re: [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-06-10 Thread James Bottomley
On Tue, 2014-06-10 at 12:57 -0700, Nicholas A. Bellinger wrote: > On Tue, 2014-06-10 at 21:45 +0300, Michael S. Tsirkin wrote: > > On Tue, Jun 10, 2014 at 10:39:17AM -0700, Nicholas A. Bellinger wrote: > > > On Tue, 2014-06-10 at 16:02 +0300, Michael S. Tsirkin wrote: > > > > On Tue, Jun 10, 2014 a

Re: [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-06-10 Thread Nicholas A. Bellinger
On Tue, 2014-06-10 at 22:35 +0300, Michael S. Tsirkin wrote: > On Tue, Jun 10, 2014 at 10:39:17AM -0700, Nicholas A. Bellinger wrote: > > On Tue, 2014-06-10 at 16:02 +0300, Michael S. Tsirkin wrote: > > > On Tue, Jun 10, 2014 at 09:52:17PM +1000, Stephen Rothwell wrote: > > > > Hi Michael, > > > >

Re: [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-06-10 Thread Nicholas A. Bellinger
On Tue, 2014-06-10 at 21:45 +0300, Michael S. Tsirkin wrote: > On Tue, Jun 10, 2014 at 10:39:17AM -0700, Nicholas A. Bellinger wrote: > > On Tue, 2014-06-10 at 16:02 +0300, Michael S. Tsirkin wrote: > > > On Tue, Jun 10, 2014 at 09:52:17PM +1000, Stephen Rothwell wrote: > > > > Hi Michael, > > > >

Re: [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-06-10 Thread Michael S. Tsirkin
On Tue, Jun 10, 2014 at 10:39:17AM -0700, Nicholas A. Bellinger wrote: > On Tue, 2014-06-10 at 16:02 +0300, Michael S. Tsirkin wrote: > > On Tue, Jun 10, 2014 at 09:52:17PM +1000, Stephen Rothwell wrote: > > > Hi Michael, > > > > > > On Tue, 10 Jun 2014 12:42:54 +0300 "Michael S. Tsirkin" > > >

Re: [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-06-10 Thread Michael S. Tsirkin
On Tue, Jun 10, 2014 at 10:39:17AM -0700, Nicholas A. Bellinger wrote: > On Tue, 2014-06-10 at 16:02 +0300, Michael S. Tsirkin wrote: > > On Tue, Jun 10, 2014 at 09:52:17PM +1000, Stephen Rothwell wrote: > > > Hi Michael, > > > > > > On Tue, 10 Jun 2014 12:42:54 +0300 "Michael S. Tsirkin" > > >

Re: [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-06-10 Thread Nicholas A. Bellinger
On Tue, 2014-06-10 at 16:02 +0300, Michael S. Tsirkin wrote: > On Tue, Jun 10, 2014 at 09:52:17PM +1000, Stephen Rothwell wrote: > > Hi Michael, > > > > On Tue, 10 Jun 2014 12:42:54 +0300 "Michael S. Tsirkin" > > wrote: > > > > > > So I see two options: > > > - I go ahead with my changes and you

Re: [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-06-10 Thread Stephen Rothwell
Hi Michael, On Tue, 10 Jun 2014 16:02:08 +0300 "Michael S. Tsirkin" wrote: > > I don't see how that's possible. > Here's a point you might have missed. > Nicholas's patch isn't just introducing a merge conflict. > It is also buggy. Ah ha! Indeed that is a different kettle of fish. :-) -- Chee

Re: [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-06-10 Thread Michael S. Tsirkin
On Tue, Jun 10, 2014 at 09:52:17PM +1000, Stephen Rothwell wrote: > Hi Michael, > > On Tue, 10 Jun 2014 12:42:54 +0300 "Michael S. Tsirkin" > wrote: > > > > So I see two options: > > - I go ahead with my changes and you with yours and let Linus resolve > > the conflict. This means bisect buil

Re: [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-06-10 Thread Stephen Rothwell
Hi Michael, On Tue, 10 Jun 2014 12:42:54 +0300 "Michael S. Tsirkin" wrote: > > So I see two options: > - I go ahead with my changes and you with yours and let Linus resolve > the conflict. This means bisect build will be broken since the > breakage will likely not be noticed until after the

Re: [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-06-10 Thread Michael S. Tsirkin
On Tue, Jun 10, 2014 at 12:05:12AM -0700, Nicholas A. Bellinger wrote: > On Mon, 2014-06-09 at 16:30 +0300, Michael S. Tsirkin wrote: > > On Thu, May 22, 2014 at 02:26:16AM +, Nicholas A. Bellinger wrote: > > > From: Nicholas Bellinger > > > > > > Hi MST, MKP, Paolo & Co, > > > > > > Here is

Re: [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-06-10 Thread Paolo Bonzini
Il 10/06/2014 09:07, Nicholas A. Bellinger ha scritto: > OK, finally went over this, looks good to me: > > Acked-by: Michael S. Tsirkin > > However, we really should stop making more changes > before fixing ANY_LAYOUT in this driver. > > virtio 1.0 should be out soon and that makes ANY_LAYOUT >

Re: [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-06-10 Thread Nicholas A. Bellinger
On Sun, 2014-06-08 at 19:05 +0300, Michael S. Tsirkin wrote: > On Thu, May 22, 2014 at 02:26:16AM +, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > Hi MST, MKP, Paolo & Co, > > > > Here is the v2 patch series for adding T1O protection information (PI) > > SGL passthrough s

Re: [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-06-10 Thread Nicholas A. Bellinger
On Mon, 2014-06-09 at 16:30 +0300, Michael S. Tsirkin wrote: > On Thu, May 22, 2014 at 02:26:16AM +, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > Hi MST, MKP, Paolo & Co, > > > > Here is the v2 patch series for adding T1O protection information (PI) > > SGL passthrough s

Re: [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-06-09 Thread Michael S. Tsirkin
On Thu, May 22, 2014 at 02:26:16AM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi MST, MKP, Paolo & Co, > > Here is the v2 patch series for adding T1O protection information (PI) > SGL passthrough support between virtio-scsi LLD + vhost-scsi fabric > endpoints. > > Follow

Re: [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-06-09 Thread Paolo Bonzini
Il 08/06/2014 18:05, Michael S. Tsirkin ha scritto: OK, finally went over this, looks good to me: Acked-by: Michael S. Tsirkin However, we really should stop making more changes before fixing ANY_LAYOUT in this driver. virtio 1.0 should be out soon and that makes ANY_LAYOUT a required featur

Re: [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-06-08 Thread Michael S. Tsirkin
On Thu, May 22, 2014 at 02:26:16AM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi MST, MKP, Paolo & Co, > > Here is the v2 patch series for adding T1O protection information (PI) > SGL passthrough support between virtio-scsi LLD + vhost-scsi fabric > endpoints. > > Follow

Re: [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-06-02 Thread Michael S. Tsirkin
On Thu, May 22, 2014 at 02:26:16AM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi MST, MKP, Paolo & Co, > > Here is the v2 patch series for adding T1O protection information (PI) > SGL passthrough support between virtio-scsi LLD + vhost-scsi fabric > endpoints. > > Follow

Re: [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-05-22 Thread Paolo Bonzini
Il 22/05/2014 04:26, Nicholas A. Bellinger ha scritto: From: Nicholas Bellinger Hi MST, MKP, Paolo & Co, Here is the v2 patch series for adding T1O protection information (PI) SGL passthrough support between virtio-scsi LLD + vhost-scsi fabric endpoints. Following MST's recommendation, it inc