Re: [PATCH] st: fix blk_get_queue usage

2017-08-07 Thread Martin K. Petersen
Hannes, > If blk_queue_get() in st_probe fails, disk->queue must not be set to > SDp->request_queue, as that would result in put_disk() dropping a not > taken reference. > > Thus, disk->queue should be set only after a successful > blk_queue_get(). Applied to 4.13/scsi-fixes. Thank you! -- Mar

Re: [PATCH] st: fix blk_get_queue usage

2017-08-01 Thread Kai Mäkisara (Kolumbus)
> On 1 Aug 2017, at 15.42, Hannes Reinecke wrote: > > From: Bodo Stroesser > > If blk_queue_get() in st_probe fails, disk->queue must not > be set to SDp->request_queue, as that would result in > put_disk() dropping a not taken reference. > > Thus, disk->queue should be set only after a succe

Re: [PATCH] st: fix blk_get_queue usage

2017-08-01 Thread Ewan D. Milne
On Tue, 2017-08-01 at 14:42 +0200, Hannes Reinecke wrote: > From: Bodo Stroesser > > If blk_queue_get() in st_probe fails, disk->queue must not > be set to SDp->request_queue, as that would result in > put_disk() dropping a not taken reference. > > Thus, disk->queue should be set only after a su