Re: [PATCH] scsi: target: add device product id and revision configfs attributes

2019-03-18 Thread Martin K. Petersen
Alan, > The product_id and revision attributes will allow for the modification > of the T10 Model and Revision strings returned in inquiry responses. > Its value can be viewed and modified via the ConfigFS path at: Applied to 5.2/scsi-queue. Thank you. -- Martin K. Petersen Oracle Linux

Re: [PATCH] scsi: target: add device product id and revision configfs attributes

2019-03-05 Thread Bart Van Assche
On Fri, 2019-03-01 at 14:44 -0800, Alan Adamson wrote: > + for (i = 0; i < len; i++) { > + if ((buf[i] < 0x20) || (buf[i] > 0x7E)) { If you have to repost this patch please leave out the superfluous parentheses. Otherwise this patch looks good to me. Hence: Reviewed-by: Bart Van A