Re: [PATCH] scsi: libiscsi: Allow sd_shutdown on bad transport

2018-01-03 Thread Martin K. Petersen
Rafael, > If, for any reason, userland shuts down iscsi transport interfaces > before proper logouts - like when logging in to LUNs manually, without > logging out on server shutdown, or when automated scripts can't > umount/logout from logged LUNs - kernel will hang forever on its > sd_sync_cach

Re: [PATCH] scsi: libiscsi: Allow sd_shutdown on bad transport

2018-01-02 Thread Lee Duncan
On 12/07/2017 01:59 PM, Rafael David Tinoco wrote: > If, for any reason, userland shuts down iscsi transport interfaces > before proper logouts - like when logging in to LUNs manually, > without logging out on server shutdown, or when automated scripts > can't umount/logout from logged LUNs - ker

Re: [PATCH] scsi: libiscsi: Allow sd_shutdown on bad transport

2017-12-31 Thread Rafael Tinoco
Hello Lee, I saw there was a reply from Lee to googlegroups (https://goo.gl/x8LhFm). I haven't responded before because I was subscribed only to linux-scsi@, my bad. Yes, it worked as expected. >From your question: > Rafael: > Did you test this change, i.e. shutdowns no longer hang, under test

Re: [PATCH] scsi: libiscsi: Allow sd_shutdown on bad transport

2017-12-20 Thread Martin K. Petersen
> If, for any reason, userland shuts down iscsi transport interfaces > before proper logouts - like when logging in to LUNs manually, without > logging out on server shutdown, or when automated scripts can't > umount/logout from logged LUNs - kernel will hang forever on its > sd_sync_cache() logic

Re: [PATCH] scsi: libiscsi: Allow sd_shutdown on bad transport

2017-12-08 Thread Rafael David Tinoco
Hello Bart, I am returning BLK_EH_HANDLED in iscsi_eh_cmd_timed_out(). Do you mean something different ? That paragraph means that I have tried to return BLK_EH_NOT_HANDLED first, because that would be the other option instead of BLK_EH_RESET_TIMER (which is causing this issue), but if I did

Re: [PATCH] scsi: libiscsi: Allow sd_shutdown on bad transport

2017-12-08 Thread Bart Van Assche
On Thu, 2017-12-07 at 19:59 -0200, Rafael David Tinoco wrote: > This happens because iscsi_eh_cmd_timed_out(), the transport layer > timeout helper, would tell the queue timeout function (scsi_times_out) > to reset the request timer over and over, until the session state is > back to logged in stat

Re: [PATCH] scsi: libiscsi: Allow sd_shutdown on bad transport

2017-12-08 Thread Rafael David Tinoco
Lee, Chris, Some test results. - Single unmounted disk, with transport connection wiped before final logout: http://pastebin.ubuntu.com/26139576/ - Multiple mounted disks, multipath dev-mapper, all transport connections were wiped before the final logout, with heavy write workload: http://pas