Re: [PATCH] scsi: cxgbi: remove redundant __kfree_skb call on skb

2019-04-09 Thread Dan Carpenter
On Tue, Apr 09, 2019 at 04:33:59PM +0200, walter harms wrote: > > > Am 09.04.2019 15:38, schrieb Colin King: > > From: Colin Ian King > > > > The error return path via label rel_resource checks for a non-null > > skb before free'ing it. However, skb is always null at this exit > > path, so the

Re: [PATCH] scsi: cxgbi: remove redundant __kfree_skb call on skb

2019-04-09 Thread walter harms
Am 09.04.2019 15:38, schrieb Colin King: > From: Colin Ian King > > The error return path via label rel_resource checks for a non-null > skb before free'ing it. However, skb is always null at this exit > path, so the null check and the free are redundant and can be removed. > Removing this al