Re: [PATCH] qla2xxx: Fix endianness of task management response code

2012-09-22 Thread Nicholas A. Bellinger
On Wed, 2012-09-19 at 00:43 -0500, Saurav Kashyap wrote: > > >From: Roland Dreier > > > >The qla2xxx firmware actually expects the task management response > >code in a CTIO IOCB with SCSI status mode 1 to be in little-endian > >byte order, ie the response code should be the first byte in the > >

Re: [PATCH] qla2xxx: Fix endianness of task management response code

2012-09-21 Thread Roland Dreier
On Fri, Sep 21, 2012 at 1:02 AM, James Bottomley wrote: > The data in status1 appears to get used a word at a time ... what about > the other three bytes you don't set; are they guaranteed to be zero? (in > which case this works, it just looks wrong from the way the thing is > used in the rest of

Re: [PATCH] qla2xxx: Fix endianness of task management response code

2012-09-21 Thread James Bottomley
On Wed, 2012-09-19 at 07:09 -0700, Roland Dreier wrote: > On Wed, Sep 19, 2012 at 12:59 AM, James Bottomley > wrote: > > Is this also true on Big Endian Hardware? Because the fix you have > > assumes that the TIO IOCB with SCSI status mode 1 should be CPU > > endian ... that doesn't look right si

Re: [PATCH] qla2xxx: Fix endianness of task management response code

2012-09-19 Thread Roland Dreier
On Wed, Sep 19, 2012 at 12:59 AM, James Bottomley wrote: > Is this also true on Big Endian Hardware? Because the fix you have > assumes that the TIO IOCB with SCSI status mode 1 should be CPU > endian ... that doesn't look right since this is passed directly over > the PCI bus (and the PCI bus is

Re: [PATCH] qla2xxx: Fix endianness of task management response code

2012-09-19 Thread James Bottomley
On Tue, 2012-09-18 at 15:10 -0700, Roland Dreier wrote: > From: Roland Dreier > > The qla2xxx firmware actually expects the task management response > code in a CTIO IOCB with SCSI status mode 1 to be in little-endian > byte order, ie the response code should be the first byte in the > sense_data

Re: [PATCH] qla2xxx: Fix endianness of task management response code

2012-09-19 Thread Saurav Kashyap
Acked-by: Saurav Kashyap Thanks, ~Saurav >On Tue, 2012-09-18 at 15:10 -0700, Roland Dreier wrote: >> From: Roland Dreier >> >> The qla2xxx firmware actually expects the task management response >> code in a CTIO IOCB with SCSI status mode 1 to be in little-endian >> byte order, ie the response

Re: [PATCH] qla2xxx: Fix endianness of task management response code

2012-09-18 Thread Saurav Kashyap
>From: Roland Dreier > >The qla2xxx firmware actually expects the task management response >code in a CTIO IOCB with SCSI status mode 1 to be in little-endian >byte order, ie the response code should be the first byte in the >sense_data[] array. The old code erroneously byte-swapped the >respon

Re: [PATCH] qla2xxx: Fix endianness of task management response code

2012-09-18 Thread Nicholas A. Bellinger
On Tue, 2012-09-18 at 15:10 -0700, Roland Dreier wrote: > From: Roland Dreier > > The qla2xxx firmware actually expects the task management response > code in a CTIO IOCB with SCSI status mode 1 to be in little-endian > byte order, ie the response code should be the first byte in the > sense_data