Re: [PATCH] libiscsi: avoid unnecessary multiple NULL assignments

2012-08-13 Thread Mike Christie
On 08/13/2012 06:59 AM, Masatake YAMATO wrote: > In iscsi_free_task, NULL is assigned to task->sc twice: before and > after kfifo_in invocatoin. Allocating and freeing iscsi_task are guarded > with session->lock, so multiple NULL assignments cause no trouble. But > people reading the source code ma

Re: [PATCH] libiscsi: avoid unnecessary multiple NULL assignments

2012-08-12 Thread Michael Christie
Replacing linux-scsi list with linux-kernel. On Aug 12, 2012, at 9:15 AM, Masatake YAMATO wrote: > In iscsi_free_task, NULL is assigned to task->sc twice: before and > after kfifo_in invocatoin. Allocating and freeing iscsi_task are guarded > with session->lock, so multiple NULL assignments caus