Re: [PATCH] libfc: replace 'rp_mutex' with 'rp_lock'

2016-05-17 Thread Bart Van Assche
On 05/16/2016 11:46 PM, Hannes Reinecke wrote: On 05/11/2016 04:44 PM, Bart Van Assche wrote: On 05/10/16 23:07, Hannes Reinecke wrote: On 05/11/2016 07:49 AM, Hannes Reinecke wrote: RIP: 0010:[] [] fc_rport_lookup+0x4b/0x70 [libfc] Call Trace: [] fc_rport_create+0x17/0x1b0 [libfc] [] fc

Re: [PATCH] libfc: replace 'rp_mutex' with 'rp_lock'

2016-05-16 Thread Hannes Reinecke
On 05/11/2016 04:44 PM, Bart Van Assche wrote: On 05/10/16 23:07, Hannes Reinecke wrote: On 05/11/2016 07:49 AM, Hannes Reinecke wrote: RIP: 0010:[] [] fc_rport_lookup+0x4b/0x70 [libfc] Call Trace: [] fc_rport_create+0x17/0x1b0 [libfc] [] fc_disc_recv_req+0x261/0x480 [libfc] [] fc_lpor

Re: [PATCH] libfc: replace 'rp_mutex' with 'rp_lock'

2016-05-11 Thread Bart Van Assche
On 05/10/16 23:07, Hannes Reinecke wrote: On 05/11/2016 07:49 AM, Hannes Reinecke wrote: RIP: 0010:[] [] fc_rport_lookup+0x4b/0x70 [libfc] Call Trace: [] fc_rport_create+0x17/0x1b0 [libfc] [] fc_disc_recv_req+0x261/0x480 [libfc] [] fc_lport_recv_els_req+0x68/0x130 [libfc] [] fc_lport

Re: [PATCH] libfc: replace 'rp_mutex' with 'rp_lock'

2016-05-10 Thread Hannes Reinecke
On 05/11/2016 07:49 AM, Hannes Reinecke wrote: > On 05/10/2016 08:33 PM, Bart Van Assche wrote: >> On 04/25/2016 01:01 AM, Hannes Reinecke wrote: >>> We cannot use an embedded mutex in a structure with reference >>> counting, as mutex unlock might be delayed, and the waiters >>> might then access a

Re: [PATCH] libfc: replace 'rp_mutex' with 'rp_lock'

2016-05-10 Thread Hannes Reinecke
On 05/10/2016 08:33 PM, Bart Van Assche wrote: > On 04/25/2016 01:01 AM, Hannes Reinecke wrote: >> We cannot use an embedded mutex in a structure with reference >> counting, as mutex unlock might be delayed, and the waiters >> might then access an already freed memory area. >> So convert it to a sp

Re: [PATCH] libfc: replace 'rp_mutex' with 'rp_lock'

2016-05-10 Thread Martin K. Petersen
> "Bart" == Bart Van Assche writes: Bart> Is what you describe a theoretical concern or have you observed Bart> any issues that could have been caused by the rport mutex? I believe Ewan had some data. Ewan? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this lis

Re: [PATCH] libfc: replace 'rp_mutex' with 'rp_lock'

2016-05-10 Thread Bart Van Assche
On 04/25/2016 01:01 AM, Hannes Reinecke wrote: We cannot use an embedded mutex in a structure with reference counting, as mutex unlock might be delayed, and the waiters might then access an already freed memory area. So convert it to a spinlock. > > For details cf https://lkml.org/lkml/2015/2/11

Re: [PATCH] libfc: replace 'rp_mutex' with 'rp_lock'

2016-05-09 Thread Johannes Thumshirn
On Mon, Apr 25, 2016 at 10:01:33AM +0200, Hannes Reinecke wrote: > We cannot use an embedded mutex in a structure with reference > counting, as mutex unlock might be delayed, and the waiters > might then access an already freed memory area. > So convert it to a spinlock. > > For details cf https:/

Re: [PATCH] libfc: replace 'rp_mutex' with 'rp_lock'

2016-04-25 Thread Ewan D. Milne
On Mon, 2016-04-25 at 10:01 +0200, Hannes Reinecke wrote: > We cannot use an embedded mutex in a structure with reference > counting, as mutex unlock might be delayed, and the waiters > might then access an already freed memory area. > So convert it to a spinlock. > > For details cf https://lkml.o