Re: [PATCH] iscsi: Capture iscsi debug messages using tracepoints

2018-12-20 Thread Martin K. Petersen
Fred, > This commit enhances iscsi initiator modules to capture iscsi debug > messages using linux kernel tracepoint facility: Applied to 4.21/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] iscsi: Capture iscsi debug messages using tracepoints

2018-12-20 Thread Douglas Gilbert
On 2018-12-20 4:45 p.m., Fred Herard wrote: ping(Doug); Thanks, Fred On 12/9/2018 5:01 PM, Fred Herard wrote: Gentle reminder... Reviewed-by: Rajan Shanmugavelu Reviewed-by: Lee Duncan Reviewed-by: Douglas Gilbert Thanks. Doug Gilbert On 12/2/2018 1:47 AM, Fred Herard wrote: Hi Dou

Re: [PATCH] iscsi: Capture iscsi debug messages using tracepoints

2018-12-20 Thread Fred Herard
ping(Doug); Thanks, Fred On 12/9/2018 5:01 PM, Fred Herard wrote: > Gentle reminder... > > Reviewed-by: Rajan Shanmugavelu > Reviewed-by: Lee Duncan > > Thanks, > Fred > > On 12/2/2018 1:47 AM, Fred Herard wrote: >> Hi Doug, >> >> Here's an updated patch with removal of the misplaced semicol

Re: [PATCH] iscsi: Capture iscsi debug messages using tracepoints

2018-12-09 Thread Fred Herard
Gentle reminder... Reviewed-by: Rajan Shanmugavelu Reviewed-by: Lee Duncan Thanks, Fred On 12/2/2018 1:47 AM, Fred Herard wrote: > Hi Doug, > > Here's an updated patch with removal of the misplaced semicolons: > > From da1f3c2ff78881c439d53820f3b82d4c54ac5cf9 Mon Sep 17 00:00:00 2001 > From:

Re: [PATCH] iscsi: Capture iscsi debug messages using tracepoints

2018-12-01 Thread Fred Herard
Hi Doug, Here's an updated patch with removal of the misplaced semicolons: >From da1f3c2ff78881c439d53820f3b82d4c54ac5cf9 Mon Sep 17 00:00:00 2001 From: Fred Herard Date: Fri, 12 Oct 2018 15:45:47 -0700 Subject: [PATCH] iscsi: Capture iscsi debug messages using tracepoints This commit enhances

Re: [PATCH] iscsi: Capture iscsi debug messages using tracepoints

2018-11-30 Thread Douglas Gilbert
Hi, Misplaced semi-colons below. On 2018-11-26 8:01 p.m., Lee Duncan wrote: On 11/21/18 9:04 AM, fred.her...@oracle.com wrote: From: Fred Herard This commit enhances iscsi initiator modules to capture iscsi debug messages using linux kernel tracepoint facility: https://www.kernel.org/doc/Doc

Re: [PATCH] iscsi: Capture iscsi debug messages using tracepoints

2018-11-27 Thread Fred Herard
Doug, Response is inline below. On 11/26/2018 08:41 PM, Douglas Gilbert wrote: Lee, See about 3/4 of the way down your patch. Summary: how about generalizing the message logging to tracefs so the whole SCSI subsystem can use it? Doug Gilbert On 2018-11-26 8:01 p.m., Lee Duncan wrote: On 11

Re: [PATCH] iscsi: Capture iscsi debug messages using tracepoints

2018-11-26 Thread Douglas Gilbert
Lee, See about 3/4 of the way down your patch. Summary: how about generalizing the message logging to tracefs so the whole SCSI subsystem can use it? Doug Gilbert On 2018-11-26 8:01 p.m., Lee Duncan wrote: On 11/21/18 9:04 AM, fred.her...@oracle.com wrote: From: Fred Herard This commit enh

Re: [PATCH] iscsi: Capture iscsi debug messages using tracepoints

2018-11-26 Thread Lee Duncan
On 11/21/18 9:04 AM, fred.her...@oracle.com wrote: > From: Fred Herard > > This commit enhances iscsi initiator modules to capture iscsi debug messages > using linux kernel tracepoint facility: > > https://www.kernel.org/doc/Documentation/trace/tracepoints.txt > > The following tracepoint event