Re: [2.6 patch] scsi/qla4xxx/ql4_isr.c: remove dead code

2008-02-21 Thread Rolf Eike Beer
> The correct patch needs to be > > Signed-off-by: David C Somayajulu <[EMAIL PROTECTED]> > > --- > > diff --git a/drivers/scsi/qla4xxx/ql4_isr.c > b/drivers/scsi/qla4xxx/ql4_isr.c > index 0f029d0..fc84db4 100644 > --- a/drivers/scsi/qla4xxx/ql4_isr.c > +++ b/drivers/scsi/qla4xxx/ql4_isr.c > @@ -10

RE: [2.6 patch] scsi/qla4xxx/ql4_isr.c: remove dead code

2008-02-21 Thread David Somayajulu
Andrew Vasquez wrote: > > > Hmm, guess it's the earlier 'if (scsi_status == 0)' check > a few lines > > > up... Dave S., can you take a look at this... Thanks, av > > > > Ah, so the !scsi_status is wrong it was supposed to be > scsi_status != > > 0 ... and even then it can just be dropped.

Re: [2.6 patch] scsi/qla4xxx/ql4_isr.c: remove dead code

2008-02-19 Thread Andrew Vasquez
On Tue, 19 Feb 2008, James Bottomley wrote: > On Tue, 2008-02-19 at 18:35 -0800, Andrew Vasquez wrote: > > On Tue, 19 Feb 2008, James Bottomley wrote: > > > > > On Tue, 2008-02-19 at 21:29 +0200, Adrian Bunk wrote: > > > > This patch removes dead code spotted by the Coverity checker. > > > > > >

Re: [2.6 patch] scsi/qla4xxx/ql4_isr.c: remove dead code

2008-02-19 Thread James Bottomley
On Tue, 2008-02-19 at 18:35 -0800, Andrew Vasquez wrote: > On Tue, 19 Feb 2008, James Bottomley wrote: > > > On Tue, 2008-02-19 at 21:29 +0200, Adrian Bunk wrote: > > > This patch removes dead code spotted by the Coverity checker. > > > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > >

Re: [2.6 patch] scsi/qla4xxx/ql4_isr.c: remove dead code

2008-02-19 Thread Andrew Vasquez
On Tue, 19 Feb 2008, James Bottomley wrote: > On Tue, 2008-02-19 at 21:29 +0200, Adrian Bunk wrote: > > This patch removes dead code spotted by the Coverity checker. > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > > > --- > > > > drivers/scsi/qla4xxx/ql4_isr.c | 18 +--

Re: [2.6 patch] scsi/qla4xxx/ql4_isr.c: remove dead code

2008-02-19 Thread James Bottomley
On Tue, 2008-02-19 at 21:29 +0200, Adrian Bunk wrote: > This patch removes dead code spotted by the Coverity checker. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > --- > > drivers/scsi/qla4xxx/ql4_isr.c | 18 +- > 1 file changed, 1 insertion(+), 17 deletions(-) > > -