Re: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR

2016-09-29 Thread Martin K. Petersen
> "Kiwoong" == Kiwoong Kim writes: Kiwoong> I think that the patch is correct. UFS spec says "The Data Kiwoong> Segment area is empty" for Read Descriptor. I have been using Kiwoong> similar code with it and it works. That have been already Kiwoong> applied in Android kernel. That's fine.

Re: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR

2016-09-28 Thread subhashj
On 2016-09-27 22:14, Martin K. Petersen wrote: "Subhash" == subhashj writes: Subhash> Looks good to me. - /* Data segment length */ - ucd_req_ptr->header.dword_2 = UPIU_HEADER_DWORD( - 0, 0, len >> 8, (u8)len); + /* Data segment length only need for W

RE: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR

2016-09-27 Thread Kiwoong Kim
peter...@oracle.com; linux-scsi@vger.kernel.org; linux- > ker...@vger.kernel.org; linux-scsi-ow...@vger.kernel.org > Subject: Re: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR > > >>>>> "Subhash" == subhashj writes: > > Subhash> Looks good to

Re: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR

2016-09-27 Thread Martin K. Petersen
> "Subhash" == subhashj writes: Subhash> Looks good to me. > - /* Data segment length */ > - ucd_req_ptr->header.dword_2 = UPIU_HEADER_DWORD( > - 0, 0, len >> 8, (u8)len); > + /* Data segment length only need for WRITE_DESC */ > + if (query->request.upiu_

Re: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR

2016-09-27 Thread subhashj
Looks good to me. Reviewed-by: Subhash Jadavani On 2016-08-25 02:39, Zang Leigang wrote: Some device may cause a compatibility issue while receiving a Query UPIU with Data Segment which does not expected. Signed-off-by: Zang Leigang --- drivers/scsi/ufs/ufshcd.c | 9 ++--- 1 file change