Re: [PATCH 4/6] st: call scsi_set_medium_removal directly

2014-11-09 Thread Kai Mäkisara (Kolumbus)
> On 7.11.2014, at 1.54, Elliott, Robert (Server Storage) > wrote: > ... > 3. Reviewing the callers, st_release has an initialized > result variable but does nothing else with it but return it: > int result = 0; > ... > return result; > > It ignores the do_door_lock -> scsi_s

Re: [PATCH 4/6] st: call scsi_set_medium_removal directly

2014-11-08 Thread Christoph Hellwig
On Thu, Nov 06, 2014 at 11:54:41PM +, Elliott, Robert (Server Storage) wrote: > A few comments spawned by this (and patch 5/6): > > 1. Although PREVENT ALLOW MEDIUM REMOVAL was a generic > command defined in SPC-2, In 2006 T10 proposal > 06-248r1 changed it to be a command-set specific > com

RE: [PATCH 4/6] st: call scsi_set_medium_removal directly

2014-11-06 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@lst.de] > Sent: Thursday, 30 October, 2014 4:27 AM > To: linux-scsi@vger.kernel.org > Cc: Douglas Gilbert; Elliott, Robert (Server Storage) > Subject: [PATCH 4/6] st: call scsi_set_medium_removal directly > > Signed-off-by: Christ

Re: [PATCH 4/6] st: call scsi_set_medium_removal directly

2014-11-05 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.

Re: [PATCH 4/6] st: call scsi_set_medium_removal directly

2014-11-05 Thread Hannes Reinecke
On 10/30/2014 10:27 AM, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > drivers/scsi/st.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c > index 7d2e036..e46e02b2 100644 > --- a/drivers/scsi/st.c >