RE: [PATCH 1/6] scsi: refactor scsi_reset_provider handling

2014-11-06 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Christoph Hellwig > Sent: Thursday, 30 October, 2014 4:27 AM > To: linux-scsi@vger.kernel.org > Cc: Douglas Gilbert; Elliott, Robert (Server Storage) > Subject: [PATCH 1

Re: [PATCH 1/6] scsi: refactor scsi_reset_provider handling

2014-11-05 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph> Pull the common code from the two callers into the function, Christoph> and renamed it to scsi_ioctl_reset. s/renamed/rename/ Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from t

Re: [PATCH 1/6] scsi: refactor scsi_reset_provider handling

2014-11-05 Thread Hannes Reinecke
On 10/30/2014 10:27 AM, Christoph Hellwig wrote: > Pull the common code from the two callers into the function, > and renamed it to scsi_ioctl_reset. > > Signed-off-by: Christoph Hellwig Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h..

Re: [PATCH 1/6] scsi: refactor scsi_reset_provider handling

2014-10-30 Thread Hannes Reinecke
On 10/30/2014 10:27 AM, Christoph Hellwig wrote: > Pull the common code from the two callers into the function, > and renamed it to scsi_ioctl_reset. > > Signed-off-by: Christoph Hellwig Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h..

Re: [PATCH 1/6] scsi: refactor scsi_reset_provider handling

2014-10-28 Thread Christoph Hellwig
On Tue, Oct 28, 2014 at 09:51:12AM +0100, Bart Van Assche wrote: > This function returns 0 even if an action like SG_SCSI_RESET_BUS fails (rtn > != SUCCESS) with the flag SCSI_TRY_RESET_NO_ESCALATE set. I think the > current behavior is to return -EIO in that case. If this change was > intended,

Re: [PATCH 1/6] scsi: refactor scsi_reset_provider handling

2014-10-28 Thread Bart Van Assche
On 10/27/14 18:59, Christoph Hellwig wrote: -/* - * Function: scsi_reset_provider - * - * Purpose:Send requested reset to a bus or device at any phase. - * - * Arguments: device - device to send reset to - * flag - reset type (see scsi.h) - * - * Returns:SUCCESS/FAILURE. -