Re: [PATCH 1/5] megaraid_sas: switch to pci_alloc_irq_vectors

2016-11-14 Thread Christoph Hellwig
> if (instance->msix_vectors) > for (i = 0; i < instance->msix_vectors; i++) { > + free_irq(pci_irq_vector(instance->pdev, i), >&instance->irq_context[i]); > } > else > + free_irq(pci_irq_vector(

Re: [PATCH 1/5] megaraid_sas: switch to pci_alloc_irq_vectors

2016-11-14 Thread Christoph Hellwig
On Fri, Nov 11, 2016 at 03:59:05PM +0100, Hannes Reinecke wrote: > You are right; irq affinity only makes sense for MSI-X. > I'll be fixing it up. It works for multi-MSI and MSI-X. And even for single-MSI or INTx it's harmless as it will be ignored if only a single vector is present. -- To unsubs

Re: [PATCH 1/5] megaraid_sas: switch to pci_alloc_irq_vectors

2016-11-11 Thread Hannes Reinecke
On 11/11/2016 12:32 PM, Sumit Saxena wrote: >> -Original Message- >> From: Hannes Reinecke [mailto:h...@suse.de] >> Sent: Friday, November 11, 2016 3:15 PM >> To: Martin K. Petersen >> Cc: Christoph Hellwig; James Bottomley; Sumit Saxena; linux- >> s...@vger.kernel.org; Hannes Reinecke; Han

RE: [PATCH 1/5] megaraid_sas: switch to pci_alloc_irq_vectors

2016-11-11 Thread Sumit Saxena
>-Original Message- >From: Hannes Reinecke [mailto:h...@suse.de] >Sent: Friday, November 11, 2016 3:15 PM >To: Martin K. Petersen >Cc: Christoph Hellwig; James Bottomley; Sumit Saxena; linux- >s...@vger.kernel.org; Hannes Reinecke; Hannes Reinecke >Subject: [PATCH 1/5] megaraid_sas: switch