RE: [PATCH 1/2] replace sizeof sense_buffer with SCSI_SENSE_BUFFERSIZE

2008-01-04 Thread FUJITA Tomonori
On Thu, 3 Jan 2008 11:10:04 -0500 "Salyzyn, Mark" <[EMAIL PROTECTED]> wrote: > ACK on aacraid/ips/dpt_i2o bits. Inspected others, this patch IS inert. Thanks! > NitMeBeingStupidAndAddingARiderToTheBill: I know it was a grep/replace. > If you need to respin because of Boaz and do not mind, do no

RE: [PATCH 1/2] replace sizeof sense_buffer with SCSI_SENSE_BUFFERSIZE

2008-01-03 Thread Salyzyn, Mark
ACK on aacraid/ips/dpt_i2o bits. Inspected others, this patch IS inert. NitMeBeingStupidAndAddingARiderToTheBill: I know it was a grep/replace. If you need to respin because of Boaz and do not mind, do not hesitate to optimize (?) and instead do: diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi

Re: [PATCH 1/2] replace sizeof sense_buffer with SCSI_SENSE_BUFFERSIZE

2008-01-03 Thread FUJITA Tomonori
On Thu, 03 Jan 2008 17:01:11 +0200 Boaz Harrosh <[EMAIL PROTECTED]> wrote: > On Thu, Jan 03 2008 at 6:56 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > > To remove sense_buffer array in scsi_cmnd structure, this replaces > > sizeof sense_buffer with SCSI_SENSE_BUFFERSIZE in several LLDs. > >

Re: [PATCH 1/2] replace sizeof sense_buffer with SCSI_SENSE_BUFFERSIZE

2008-01-03 Thread Boaz Harrosh
On Thu, Jan 03 2008 at 6:56 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > To remove sense_buffer array in scsi_cmnd structure, this replaces > sizeof sense_buffer with SCSI_SENSE_BUFFERSIZE in several LLDs. > > Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> > --- > drivers/ata/libata-sc