Re: [PATCH] scsi: aacraid: Add a small delay after IOP reset

2017-09-27 Thread Martin K. Petersen
Dave, >> > Previously we had used sleep to delay until the controller got its > mind back, but early testing indicated it wasn't needed. I'm good with > this. Applied to 4.14/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering

RE: [PATCH] scsi: aacraid: Add a small delay after IOP reset

2017-09-27 Thread Dave Carroll
> > > Guilherme, > > > James/Martin, am I expected to send a v2 with some change? Perhaps > > with Dave's ack? Sorry to annoy, thanks in advance for any advice! > > I was just about to mail Dave and ask for confirmation that your > interpretation > of the controller behavior is correct. > >

Re: [PATCH] scsi: aacraid: Add a small delay after IOP reset

2017-09-25 Thread Martin K. Petersen
Guilherme, > James/Martin, am I expected to send a v2 with some change? Perhaps > with Dave's ack? Sorry to annoy, thanks in advance for any advice! I was just about to mail Dave and ask for confirmation that your interpretation of the controller behavior is correct. Dave? -- Martin K. Peter

Re: [PATCH] scsi: aacraid: Add a small delay after IOP reset

2017-09-25 Thread Guilherme G. Piccoli
On 09/21/2017 01:19 PM, Dave Carroll wrote: >> [...] >> --- > Acked-by: Dave Carroll > Thanks Dave! James/Martin, am I expected to send a v2 with some change? Perhaps with Dave's ack? Sorry to annoy, thanks in advance for any advice! Cheers, Guilherme

RE: [PATCH] scsi: aacraid: Add a small delay after IOP reset

2017-09-21 Thread Dave Carroll
> From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com] > Sent: Tuesday, September 19, 2017 9:12 AM > To: dl-esc-Aacraid Linux Driver ; linux- > s...@vger.kernel.org > Cc: gpicc...@linux.vnet.ibm.com; Raghava Aditya Renukunta > ; Dave Carroll > ; brk...@linux.vnet.ibm.com; > dougm...@linu

Re: [PATCH] scsi: aacraid: Add a small delay after IOP reset

2017-09-19 Thread Guilherme G. Piccoli
On 09/19/2017 02:05 PM, James Bottomley wrote: > Actually, the whole problem sounds like a posted write. Likely the > write that causes the reset doesn't get flushed until the read checking > if the reset has succeeded, which might explain the 100% initial > failure. Why not throw away that first

Re: [PATCH] scsi: aacraid: Add a small delay after IOP reset

2017-09-19 Thread James Bottomley
On Tue, 2017-09-19 at 08:52 -0700, Christoph Hellwig wrote: > On Tue, Sep 19, 2017 at 12:49:21PM -0300, Guilherme G. Piccoli wrote: > > > > On 09/19/2017 12:37 PM, Christoph Hellwig wrote: > > > > > > On Tue, Sep 19, 2017 at 12:11:55PM -0300, Guilherme G. Piccoli > > > wrote: > > > > > > > >  

Re: [PATCH] scsi: aacraid: Add a small delay after IOP reset

2017-09-19 Thread Guilherme G. Piccoli
On 09/19/2017 12:52 PM, Christoph Hellwig wrote: > On Tue, Sep 19, 2017 at 12:49:21PM -0300, Guilherme G. Piccoli wrote: >> On 09/19/2017 12:37 PM, Christoph Hellwig wrote: >>> On Tue, Sep 19, 2017 at 12:11:55PM -0300, Guilherme G. Piccoli wrote: src_writel(dev, MUnit.IDR, IOP_SRC_RESET_MAS

Re: [PATCH] scsi: aacraid: Add a small delay after IOP reset

2017-09-19 Thread Christoph Hellwig
On Tue, Sep 19, 2017 at 12:49:21PM -0300, Guilherme G. Piccoli wrote: > On 09/19/2017 12:37 PM, Christoph Hellwig wrote: > > On Tue, Sep 19, 2017 at 12:11:55PM -0300, Guilherme G. Piccoli wrote: > >>src_writel(dev, MUnit.IDR, IOP_SRC_RESET_MASK); > >> + > >> + msleep(5000); > > > > src_writel

Re: [PATCH] scsi: aacraid: Add a small delay after IOP reset

2017-09-19 Thread Guilherme G. Piccoli
On 09/19/2017 12:37 PM, Christoph Hellwig wrote: > On Tue, Sep 19, 2017 at 12:11:55PM -0300, Guilherme G. Piccoli wrote: >> src_writel(dev, MUnit.IDR, IOP_SRC_RESET_MASK); >> + >> +msleep(5000); > > src_writel is a writel, and thus a posted MMIO write. You'll need > to have to a read fir

Re: [PATCH] scsi: aacraid: Add a small delay after IOP reset

2017-09-19 Thread Christoph Hellwig
On Tue, Sep 19, 2017 at 12:11:55PM -0300, Guilherme G. Piccoli wrote: > src_writel(dev, MUnit.IDR, IOP_SRC_RESET_MASK); > + > + msleep(5000); src_writel is a writel, and thus a posted MMIO write. You'll need to have to a read first to make it a reliable timing base.