Re: [PATCH] pm80xx: Spinlock fix

2013-12-23 Thread Oleg Nesterov
On 12/23, Jason Seba wrote: > > Wouldn't the contents of the global flags value be protected by the > spinlock itself? This can be even true because nowadays spin_lock_irqsave() writes to "flags" after it takes the lock, and _irqrestore works gets the copy of "flags" before it releases the lock.

Re: [PATCH] pm80xx: Spinlock fix

2013-12-23 Thread Oleg Nesterov
On 12/23, Tomas Henzl wrote: > > On 12/23/2013 04:06 PM, Jack Wang wrote: > > On 12/23/2013 03:55 PM, Jason Seba wrote: > >> Why is this considered dangerous? I put some thought into it and > >> couldn't find any obvious reason why it wouldn't work, but I also > >> couldn't find any other drivers

Re: [PATCH] pm80xx: Spinlock fix

2013-12-23 Thread Tomas Henzl
>> wrote: >>>>> -Original Message- >>>>> From: Jack Wang [mailto:xjtu...@gmail.com] >>>>> Sent: Monday, December 23, 2013 7:03 PM >>>>> To: Tomas Henzl; Viswas G >>>>> Cc: linux-scsi@vger.kernel.org; ja

Re: [PATCH] pm80xx: Spinlock fix

2013-12-23 Thread Jason Seba
Mon, Dec 23, 2013 at 8:45 AM, Suresh Thiagarajan >>> wrote: >>>> >>>> -Original Message- >>>> From: Jack Wang [mailto:xjtu...@gmail.com] >>>> Sent: Monday, December 23, 2013 7:03 PM >>>> To: Tomas Henzl; Viswas G >>

Re: [PATCH] pm80xx: Spinlock fix

2013-12-23 Thread Tomas Henzl
; jason.seb...@gmail.com; >>> jbottom...@parallels.com; Vasanthalakshmi Tharmarajan; Suresh Thiagarajan >>> Subject: Re: [PATCH] pm80xx: Spinlock fix >>> >>> On 12/23/2013 02:07 PM, Tomas Henzl wrote: >>>> On 12/18/2013 12:28 PM, Viswas G wrote: >

Re: [PATCH] pm80xx: Spinlock fix

2013-12-23 Thread Jack Wang
nday, December 23, 2013 7:03 PM >> To: Tomas Henzl; Viswas G >> Cc: linux-scsi@vger.kernel.org; jason.seb...@gmail.com; >> jbottom...@parallels.com; Vasanthalakshmi Tharmarajan; Suresh Thiagarajan >> Subject: Re: [PATCH] pm80xx: Spinlock fix >> >

Re: [PATCH] pm80xx: Spinlock fix

2013-12-23 Thread Jason Seba
armarajan; Suresh Thiagarajan > Subject: Re: [PATCH] pm80xx: Spinlock fix > > On 12/23/2013 02:07 PM, Tomas Henzl wrote: >> On 12/18/2013 12:28 PM, Viswas G wrote: >>> From 9338d4bc92b23b4c283f9bd6812646ab74866a40 Mon Sep 17 00:00:00 >>> 2001 >>> From: Suresh T

RE: [PATCH] pm80xx: Spinlock fix

2013-12-23 Thread Suresh Thiagarajan
-Original Message- From: Jack Wang [mailto:xjtu...@gmail.com] Sent: Monday, December 23, 2013 7:03 PM To: Tomas Henzl; Viswas G Cc: linux-scsi@vger.kernel.org; jason.seb...@gmail.com; jbottom...@parallels.com; Vasanthalakshmi Tharmarajan; Suresh Thiagarajan Subject: Re: [PATCH] pm80xx

Re: [PATCH] pm80xx: Spinlock fix

2013-12-23 Thread Jack Wang
On 12/23/2013 02:07 PM, Tomas Henzl wrote: > On 12/18/2013 12:28 PM, Viswas G wrote: >> From 9338d4bc92b23b4c283f9bd6812646ab74866a40 Mon Sep 17 00:00:00 2001 >> From: Suresh Thiagarajan >> Date: Mon, 16 Dec 2013 21:15:20 +0530 >> Subject: [PATCH] pm80xx: Spinlock fix >> >> spin_unlock was used in

Re: [PATCH] pm80xx: Spinlock fix

2013-12-23 Thread Tomas Henzl
On 12/18/2013 12:28 PM, Viswas G wrote: > From 9338d4bc92b23b4c283f9bd6812646ab74866a40 Mon Sep 17 00:00:00 2001 > From: Suresh Thiagarajan > Date: Mon, 16 Dec 2013 21:15:20 +0530 > Subject: [PATCH] pm80xx: Spinlock fix > > spin_unlock was used instead of spin_unlock_irqrestore. To fix this > loc