On Thu, 2016-05-12 at 09:35 +0300, Dan Carpenter wrote:
> On Wed, May 11, 2016 at 08:49:51PM -0500, Petros Koutoupis wrote:
> > Sumit,
> >
> > I will resubmit the patch with all the recommendations. Thank you. In case
> > you are interested, I have a crash file showcasing the error. I can always
>
On Fri, 13 May 2016, Sumit Saxena wrote:
>
> For IOs returned by above error are not actually fired to firmware so
> there will be no interrupt handler called for the same.
You don't need both possibilities to hold. Either one would do it!
--
--
To unsubscribe from this list: send the line "
m;
> megaraidlinux@avagotech.com; linux-scsi@vger.kernel.org
> Subject: RE: [PATCH] megaraid: add scsi_cmnd NULL check before use
>
>
> On Thu, 12 May 2016, Sumit Saxena wrote:
>
> > > From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> > >
> > > Also when I
On Thu, 12 May 2016, Sumit Saxena wrote:
> > From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> >
> > Also when I'm doing static analysis people always tell me that "that
> > bug is impossible, trust me." and instead of trusting people I really
> > wish they would just show me the relevant
m;
> megaraidlinux@avagotech.com; linux-scsi@vger.kernel.org
> Subject: Re: [PATCH] megaraid: add scsi_cmnd NULL check before use
>
> On Wed, May 11, 2016 at 08:49:51PM -0500, Petros Koutoupis wrote:
> > Sumit,
> >
> > I will resubmit the patch with all the recommendations. Tha
On Wed, May 11, 2016 at 08:49:51PM -0500, Petros Koutoupis wrote:
> Sumit,
>
> I will resubmit the patch with all the recommendations. Thank you. In case
> you are interested, I have a crash file showcasing the error. I can always
> provide this outside of this mailing thread.
>
Please send it t
de...@avagotech.com; sumit.sax...@avagotech.com;
> > uday.ling...@avagotech.com; megaraidlinux@avagotech.com; linux-
> > s...@vger.kernel.org
> > Subject: Re: [PATCH] megaraid: add scsi_cmnd NULL check before use
> >
> > On Mon, 2016-05-09 at 15:18 +0530, Sumit Saxena wrote:
@avagotech.com; linux-
> s...@vger.kernel.org
> Subject: Re: [PATCH] megaraid: add scsi_cmnd NULL check before use
>
> On Mon, 2016-05-09 at 15:18 +0530, Sumit Saxena wrote:
> > >
> > > -Original Message-
> > > From: Dan Carpenter [mailto:dan.carpe
.com;
> > sumit.sax...@avagotech.com; uday.ling...@avagotech.com;
> > megaraidlinux@avagotech.com; linux-scsi@vger.kernel.org
> > Subject: Re: [PATCH] megaraid: add scsi_cmnd NULL check before use
> >
> > Smatch doesn't quite catch it because we check "cmd_
I'm confused what you are saying. According to Petros, these bugs are
causing failures in real life, I was only added to the CC list because
Smatch should have warned about them.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a mess
otech.com; linux-scsi@vger.kernel.org
> Subject: Re: [PATCH] megaraid: add scsi_cmnd NULL check before use
>
> Smatch doesn't quite catch it because we check "cmd_fusion->scmd" for
NULL
> then assign "scmd_local = cmd_fusion->scmd;" and dereference scmd_loc
I've updated Smatch to catch these and I'm testing it now. We'll see
how it goes. If my quick and dirty method doesn't has too many false
positives then it's will take some months before I get around to doing
it properly...
Thanks for notifying me on this.
regards,
dan carpenter
--
To unsubscr
Smatch doesn't quite catch it because we check "cmd_fusion->scmd" for
NULL then assign "scmd_local = cmd_fusion->scmd;" and dereference
scmd_local unconditionally...
It does catch part of the bug if you have cross function analysis:
drivers/scsi/megaraid/megaraid_sas_fusion.c:2318 complete_cmd_
On Mon, 2016-05-09 at 11:35 +1000, Julian Calaby wrote:
> Hi Petros,
>
> On Mon, May 9, 2016 at 2:34 AM, Petros Koutoupis
> wrote:
> > On Sun, 2016-05-08 at 22:22 +1000, Finn Thain wrote:
> >> On Sun, 8 May 2016, Petros Koutoupis wrote:
> >>
> >> > >
> >> > > That contains a tautology.
> >> > >
>
Hi Petros,
On Mon, May 9, 2016 at 2:34 AM, Petros Koutoupis
wrote:
> On Sun, 2016-05-08 at 22:22 +1000, Finn Thain wrote:
>> On Sun, 8 May 2016, Petros Koutoupis wrote:
>>
>> > >
>> > > That contains a tautology.
>> > >
>> >
>> > How so?
>>
>> if (x)
>> /* ... */
>> else if (!x && (whatever
On Sun, 2016-05-08 at 22:22 +1000, Finn Thain wrote:
> On Sun, 8 May 2016, Petros Koutoupis wrote:
>
> > >
> > > That contains a tautology.
> > >
> >
> > How so?
>
> if (x)
> /* ... */
> else if (!x && (whatever))
> /* ... */
>
> --
Thank you but I know the logic of what I wrote
On Sun, 8 May 2016, Petros Koutoupis wrote:
> >
> > That contains a tautology.
> >
>
> How so?
if (x)
/* ... */
else if (!x && (whatever))
/* ... */
--
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.
On Sun, 2016-05-08 at 13:32 +1000, Finn Thain wrote:
> On Sat, 7 May 2016, Petros Koutoupis wrote:
>
> > The current state of the code checks to see if the reference to
> > scsi_cmnd is not null, but it never checks to see if it is null and
> > always assumes it is valid before its use in below
On Sat, 7 May 2016, Petros Koutoupis wrote:
> The current state of the code checks to see if the reference to
> scsi_cmnd is not null, but it never checks to see if it is null and
> always assumes it is valid before its use in below switch statement.
> This patch addresses that.
>
There is n
19 matches
Mail list logo
