RE: [PATCH] aic94xx: fix smartctl utility problem

2007-09-21 Thread Wu, Gilbert
, September 21, 2007 1:40 PM To: Wu, Gilbert Cc: [EMAIL PROTECTED]; Linux-scsi@vger.kernel.org Subject: RE: [PATCH] aic94xx: fix smartctl utility problem On Fri, 2007-09-21 at 11:53 -0700, Wu, Gilbert wrote: >I can reproduce the problem on my machine. Most likely, the Sequencer > (Firmware) has

RE: [PATCH] aic94xx: fix smartctl utility problem

2007-09-21 Thread James Bottomley
On Fri, 2007-09-21 at 11:53 -0700, Wu, Gilbert wrote: >I can reproduce the problem on my machine. Most likely, the Sequencer > (Firmware) has bug on handling ATA output register for ATAPI device. I > am still working on this issue with Sequencer engineer. But, since you already vet the command

RE: [PATCH] aic94xx: fix smartctl utility problem

2007-09-21 Thread Wu, Gilbert
PROTECTED] Sent: Monday, September 17, 2007 3:59 PM To: Wu, Gilbert Cc: [EMAIL PROTECTED]; Linux-scsi@vger.kernel.org Subject: RE: [PATCH] aic94xx: fix smartctl utility problem On Mon, 2007-09-17 at 13:53 -0700, Wu, Gilbert wrote: >I tested the SATA DVD Plextor model 716SA and 755SA with dir

Re: [PATCH] aic94xx: fix smartctl utility problem

2007-09-20 Thread Douglas Gilbert
James Bottomley wrote: > On Sun, 2007-09-16 at 19:01 -0400, Douglas Gilbert wrote: >> James Bottomley wrote: >>> On Sat, 2007-09-15 at 12:05 -0500, James Bottomley wrote: On Fri, 2007-09-14 at 10:58 -0700, Gilbert Wu wrote: > Fixed the problem that "smartctl -a /dev/some_sata_disk -d ata"

Re: [PATCH] aic94xx: fix smartctl utility problem

2007-09-18 Thread Luben Tuikov
--- Gilbert Wu <[EMAIL PROTECTED]> wrote: > Fixed the problem that "smartctl -a /dev/some_sata_disk -d ata" does > not work on SATA device. ( The smartctl v5.38 does need "-d ata" > option.) I'm testing my own SATL with "-d sat". > The aic94xx need to return ATA output register for all ATA com

RE: [PATCH] aic94xx: fix smartctl utility problem

2007-09-17 Thread James Bottomley
On Mon, 2007-09-17 at 18:43 -0700, Wu, Gilbert wrote: > ata_task_return code=0 > ** cmd success then the no ATA > output register return. > scsi 2:0:0:0: CD-ROMPLEXTOR DVDR PX-755A 1.02 PQ: 0 > ANSI: 5 > scsi 2:0:0:0: Attached scsi generic sg2 type 5 > ata command=a0 >

RE: [PATCH] aic94xx: fix smartctl utility problem

2007-09-17 Thread Wu, Gilbert
ailto:[EMAIL PROTECTED] Sent: Monday, September 17, 2007 3:59 PM To: Wu, Gilbert Cc: [EMAIL PROTECTED]; Linux-scsi@vger.kernel.org Subject: RE: [PATCH] aic94xx: fix smartctl utility problem On Mon, 2007-09-17 at 13:53 -0700, Wu, Gilbert wrote: >I tested the SATA DVD Plextor model 716SA and 75

RE: [PATCH] aic94xx: fix smartctl utility problem

2007-09-17 Thread James Bottomley
On Mon, 2007-09-17 at 13:53 -0700, Wu, Gilbert wrote: >I tested the SATA DVD Plextor model 716SA and 755SA with direct > attached. Both failed in my tested system and it end up with System > Panic even without my patch. Actually, because of the difficulty of wiring it up, I've not tried direct

RE: [PATCH] aic94xx: fix smartctl utility problem

2007-09-17 Thread Wu, Gilbert
! Gilbert -Original Message- From: James Bottomley [mailto:[EMAIL PROTECTED] Sent: Sunday, September 16, 2007 4:21 PM To: [EMAIL PROTECTED] Cc: Wu, Gilbert; Linux-scsi@vger.kernel.org Subject: Re: [PATCH] aic94xx: fix smartctl utility problem On Sun, 2007-09-16 at 19:01 -0400, Douglas Gilbert

Re: [PATCH] aic94xx: fix smartctl utility problem

2007-09-16 Thread James Bottomley
On Sun, 2007-09-16 at 19:01 -0400, Douglas Gilbert wrote: > James Bottomley wrote: > > On Sat, 2007-09-15 at 12:05 -0500, James Bottomley wrote: > >> On Fri, 2007-09-14 at 10:58 -0700, Gilbert Wu wrote: > >>> Fixed the problem that "smartctl -a /dev/some_sata_disk -d ata" does > >>> not work on SA

Re: [PATCH] aic94xx: fix smartctl utility problem

2007-09-16 Thread Douglas Gilbert
James Bottomley wrote: > On Sat, 2007-09-15 at 12:05 -0500, James Bottomley wrote: >> On Fri, 2007-09-14 at 10:58 -0700, Gilbert Wu wrote: >>> Fixed the problem that "smartctl -a /dev/some_sata_disk -d ata" does >>> not work on SATA device. ( The smartctl v5.38 does need "-d ata" >>> option.) >>>

Re: [PATCH] aic94xx: fix smartctl utility problem

2007-09-16 Thread Jeff Garzik
James Bottomley wrote: On Sat, 2007-09-15 at 12:05 -0500, James Bottomley wrote: On Fri, 2007-09-14 at 10:58 -0700, Gilbert Wu wrote: Fixed the problem that "smartctl -a /dev/some_sata_disk -d ata" does not work on SATA device. ( The smartctl v5.38 does need "-d ata" option.) The aic94xx nee

Re: [PATCH] aic94xx: fix smartctl utility problem

2007-09-16 Thread James Bottomley
On Sat, 2007-09-15 at 12:05 -0500, James Bottomley wrote: > On Fri, 2007-09-14 at 10:58 -0700, Gilbert Wu wrote: > > Fixed the problem that "smartctl -a /dev/some_sata_disk -d ata" does > > not work on SATA device. ( The smartctl v5.38 does need "-d ata" > > option.) > > The aic94xx need to retu

Re: [PATCH] aic94xx: fix smartctl utility problem

2007-09-15 Thread James Bottomley
On Fri, 2007-09-14 at 10:58 -0700, Gilbert Wu wrote: > Fixed the problem that "smartctl -a /dev/some_sata_disk -d ata" does > not work on SATA device. ( The smartctl v5.38 does need "-d ata" > option.) > The aic94xx need to return ATA output register for all ATA commands > except ATA Read/Write

Re: [PATCH] aic94xx: fix smartctl utility problem

2007-09-14 Thread Jeff Garzik
Gilbert Wu wrote: Fixed the problem that "smartctl -a /dev/some_sata_disk -d ata" does not work on SATA device. ( The smartctl v5.38 does need "-d ata" option.) The aic94xx need to return ATA output register for all ATA commands except ATA Read/Write commands. The aic94xx also mark out the D

RE: [PATCH] aic94xx: fix smartctl utility problem

2007-09-14 Thread Wu, Gilbert
HI Jeff, Oops! I missed that one and will resend again. Thanks! Gilbert -Original Message- From: Jeff Garzik [mailto:[EMAIL PROTECTED] Sent: Friday, September 14, 2007 10:27 AM To: Wu, Gilbert Cc: linux-scsi@vger.kernel.org Subject: Re: [PATCH] aic94xx: fix smartctl utility problem

Re: [PATCH] aic94xx: fix smartctl utility problem

2007-09-14 Thread Jeff Garzik
Gilbert Wu wrote: Fixed the problem that "smartctl -a /dev/some_sata_disk -d ata" does not work on SATA device. ( The smartctl v5.38 does need "-d ata" option.) The aic94xx need to return ATA output register for all ATA commands except ATA Read/Write commands. The aic94xx also mark out the D

RE: [PATCH] aic94xx: fix smartctl utility problem

2007-09-07 Thread Wu, Gilbert
! Gilbert -Original Message- From: Jeff Garzik [mailto:[EMAIL PROTECTED] Sent: Friday, September 07, 2007 4:01 PM To: Wu, Gilbert Cc: Linux-scsi@vger.kernel.org Subject: Re: [PATCH] aic94xx: fix smartctl utility problem Wu, Gilbert wrote: > HI Jeff, > > I was thinking the check

Re: [PATCH] aic94xx: fix smartctl utility problem

2007-09-07 Thread Jeff Garzik
Wu, Gilbert wrote: HI Jeff, I was thinking the checking "READ/WRITE" command table is larger than my current table. This does not cover vendor-specific command. You can implement the check in a _far_ more optimal manner: Possibility 1: static const u8 ata_rw_command_table[256] = {

RE: [PATCH] aic94xx: fix smartctl utility problem

2007-09-06 Thread Wu, Gilbert
he command did not succeed. Thanks! Gilbert -Original Message- From: Jeff Garzik [mailto:[EMAIL PROTECTED] Sent: Thursday, September 06, 2007 3:06 AM To: Wu, Gilbert Cc: Linux-scsi@vger.kernel.org Subject: Re: [PATCH] aic94xx: fix smartctl utility problem On Wed, Sep 05, 2007 at 03:25:

Re: [PATCH] aic94xx: fix smartctl utility problem

2007-09-06 Thread Jeff Garzik
On Wed, Sep 05, 2007 at 03:25:55PM -0700, Gilbert Wu wrote: >Fixed the problem that "smartctl -a /dev/some_sata_disk -d ata" does not > work on SATA device. >( The smartctl v5.38 does need "-d ata" option.) >The root cause is the aic94xx driver does not return ATA output register > d