Re: [PATCH] aacraid: Add likely() and unlikely()

2007-03-28 Thread Allexio Ju
On 3/28/07, Arjan van de Ven <[EMAIL PROTECTED]> wrote: On Tue, 2007-03-27 at 09:17 -0700, Allexio Ju wrote: > I thought those macros simply tell compiler to layout code in such a > way that minimizes unnecessary jumps. it's more than that. it generally also tells the processor what the branch wi

RE: [PATCH] aacraid: Add likely() and unlikely()

2007-03-28 Thread Arjan van de Ven
On Tue, 2007-03-27 at 09:17 -0700, Allexio Ju wrote: > On Thu, 2007-03-22 at 2007 2:24 AM, Arjan van de Ven wrote: > > (I assume you're aware that likely/unlikely should only be > > used for 99:1 or higher ratios, this one looks correct for sure) > Could you share details of reasons why those macro

RE: [PATCH] aacraid: Add likely() and unlikely()

2007-03-27 Thread Allexio Ju
On Thu, 2007-03-22 at 2007 2:24 AM, Arjan van de Ven wrote: (I assume you're aware that likely/unlikely should only be used for 99:1 or higher ratios, this one looks correct for sure) Could you share details of reasons why those macros should be used in the way? I thought those macros simply tel

Re: [PATCH] aacraid: Add likely() and unlikely()

2007-03-22 Thread Arjan van de Ven
On Wed, 2007-03-21 at 15:43 -0400, Salyzyn, Mark wrote: > Add some likely() and unlikely() compiler hints in some of the aacraid > hardware interface layers. There should be no operational side effects > resulting from this patch and the changes should be mostly benign on x86 > platforms. > > Obli