Re: [PATCH] [RFC] sd: make error handling more robust

2008-02-04 Thread Luben Tuikov
--- On Mon, 2/4/08, Tony Battersby <[EMAIL PROTECTED]> wrote: > I _really_ _really_ hope that you don't believe that I > am trying to take > credit for your work. If you take another look, my original > patch had > the following hunk: > > + > + /* Make sure that bad_lba is one of the s

Re: [PATCH] [RFC] sd: make error handling more robust

2008-02-04 Thread Tony Battersby
Luben Tuikov wrote: > You then took hunk #2 (2 lines) of the patch I sent > you and submitted it as your own, and then I acked > "your" patch. > I _really_ _really_ hope that you don't believe that I am trying to take credit for your work. If you take another look, my original patch had the foll

Re: [PATCH] [RFC] sd: make error handling more robust

2008-02-01 Thread Luben Tuikov
--- On Fri, 2/1/08, Tony Battersby <[EMAIL PROTECTED]> wrote: > > I disagree only with this part of the commit: > > - good_bytes = (error_sector - > SCpnt->request->sector) << 9; > - if (good_bytes < 0 || good_bytes > >= this_count) > -

Re: [PATCH] [RFC] sd: make error handling more robust

2008-02-01 Thread Tony Battersby
Luben Tuikov wrote: > --- On Fri, 2/1/08, Tony Battersby <[EMAIL PROTECTED]> wrote: > >> Also, I disagree about treating recovered error like >> hardware/medium >> error. Recovered error is supposed to mean "the last >> command completed >> successfully, with some recovery action performed by t

Re: [PATCH] [RFC] sd: make error handling more robust

2008-02-01 Thread Luben Tuikov
--- On Fri, 2/1/08, Tony Battersby <[EMAIL PROTECTED]> wrote: > > Also, I disagree about treating recovered error like > hardware/medium > error. Recovered error is supposed to mean "the last > command completed > successfully, with some recovery action performed by the > device > server". Which

Re: [PATCH] [RFC] sd: make error handling more robust

2008-02-01 Thread Tony Battersby
Salyzyn, Mark wrote: > Serendipity, been working an issue for the past week where error reporting > from aacraid's HARDWARE_ERROR when an array was marked DEAD in the Adapter > was not propagating to MD. The trigger for this investigation was "AACRAID > driver broken in 2.6.22.x (and beyond?) [W

Re: [PATCH] [RFC] sd: make error handling more robust

2008-02-01 Thread James Bottomley
On Fri, 2008-02-01 at 10:46 -0500, Tony Battersby wrote: > Luben Tuikov wrote: > > This is due to the fact that the LU/LLDD returned > > sense data with VALID = 1, and so Bad LBA is assumed > > correct. This is as per spec. At this moment given > > the situation you describe it seems that the LU/L

Re: [PATCH] [RFC] sd: make error handling more robust

2008-02-01 Thread Tony Battersby
Luben Tuikov wrote: > This is due to the fact that the LU/LLDD returned > sense data with VALID = 1, and so Bad LBA is assumed > correct. This is as per spec. At this moment given > the situation you describe it seems that the LU/LLDD > is behaving out of spec. > > I agree that my RAID (an exte

RE: [PATCH] [RFC] sd: make error handling more robust

2008-02-01 Thread Salyzyn, Mark
Serendipity, been working an issue for the past week where error reporting from aacraid's HARDWARE_ERROR when an array was marked DEAD in the Adapter was not propagating to MD. The trigger for this investigation was "AACRAID driver broken in 2.6.22.x (and beyond?) [WAS: Re: 2.6.22.16 MD raid1 do

Re: [PATCH] [RFC] sd: make error handling more robust

2008-02-01 Thread Luben Tuikov
--- On Thu, 1/31/08, Luben Tuikov <[EMAIL PROTECTED]> wrote: > Negate original: > if (driver_byte(result) == DRIVER_SENSE || > (sense_valid && sense_defered)) > Inspect sense. > > Negate your proposed change "&&" -> > "||": > if (driver_byte(result) == DRIVER_SENSE && >

Re: [PATCH] [RFC] sd: make error handling more robust

2008-01-31 Thread Luben Tuikov
--- On Thu, 1/31/08, Tony Battersby <[EMAIL PROTECTED]> wrote: > From: Tony Battersby <[EMAIL PROTECTED]> > Subject: [PATCH] [RFC] sd: make error handling more robust > To: "James Bottomley" <[EMAIL PROTECTED]>, "Luben Tuikov" <[EMAIL > PROTECTED]>, linux-scsi@vger.kernel.org > Date: Thursday, Ja