Re: [Bugfix 3/3] eata: Enhance eata driver to support PCI device hot-removal

2015-09-18 Thread Arthur Marsh
Christoph Hellwig wrote on 16/09/15 23:12: Jiang, you also need to convert the driver to scsi_add_host/scsi_remove_host from the legacy scsi_register interface, otherwise the SCSI layer will be very unhappy. Take a look at commit 0d31f8759109cbc1e6fc196d08e6b0e8a9e93b3f for example, the chang

Re: [Bugfix 3/3] eata: Enhance eata driver to support PCI device hot-removal

2015-09-16 Thread Jiang Liu
On 2015/9/16 21:42, Christoph Hellwig wrote: > On Mon, Sep 14, 2015 at 10:21:14AM +0200, Hannes Reinecke wrote: >> Welll ... if you don't have hardware (and I strongly hope you refer to >> 'hardware able to do hotplugging', not 'hardware for the eata driver' >> ...) why add the code at all? >> Chan

Re: [Bugfix 3/3] eata: Enhance eata driver to support PCI device hot-removal

2015-09-16 Thread Christoph Hellwig
On Mon, Sep 14, 2015 at 10:21:14AM +0200, Hannes Reinecke wrote: > Welll ... if you don't have hardware (and I strongly hope you refer to > 'hardware able to do hotplugging', not 'hardware for the eata driver' > ...) why add the code at all? > Chances are no-one will ever need eata PCI hotplug; SCS

Re: [Bugfix 3/3] eata: Enhance eata driver to support PCI device hot-removal

2015-09-14 Thread Jiang Liu
ernel.org; linux-...@vger.kernel.org; > linux-scsi@vger.kernel.org; x...@kernel.org > Subject: Re: [Bugfix 3/3] eata: Enhance eata driver to support PCI device > hot-removal > > On 09/14/2015 05:08 AM, Jiang Liu wrote: >> Due to having no hardware for testing, this is just a sampl

RE: [Bugfix 3/3] eata: Enhance eata driver to support PCI device hot-removal

2015-09-14 Thread Ballabio, Dario
driver to support PCI device hot-removal On 09/14/2015 05:08 AM, Jiang Liu wrote: > Due to having no hardware for testing, this is just a sample code to > support PCI device hot-removal. It just passing compilation, no any > tests. > > Signed-off-by: Jiang Liu > --- > drive

Re: [Bugfix 3/3] eata: Enhance eata driver to support PCI device hot-removal

2015-09-14 Thread Hannes Reinecke
On 09/14/2015 05:08 AM, Jiang Liu wrote: > Due to having no hardware for testing, this is just a sample code > to support PCI device hot-removal. It just passing compilation, > no any tests. > > Signed-off-by: Jiang Liu > --- > drivers/scsi/eata.c | 26 ++ > 1 file chan