Re: [2.6 patch] SCSI: possible cleanups

2005-03-01 Thread Luben Tuikov
On 03/01/05 17:17, Christoph Hellwig wrote: Doing it in the core means less duplication and avoiding updating all drivers. I agree. Luben - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger

Re: [2.6 patch] SCSI: possible cleanups

2005-03-01 Thread Christoph Hellwig
On Tue, Mar 01, 2005 at 09:40:48AM -0500, Luben Tuikov wrote: > On 03/01/05 03:14, Douglas Gilbert wrote: > >> - scsi_error.c: scsi_normalize_sense > > > > > >I introduced scsi_normalize_sense() recently, Christoph H. > >proposed it should be static but Luben Tuikov (aic7xxx > >maintainer) said he

Re: [2.6 patch] SCSI: possible cleanups

2005-03-01 Thread Luben Tuikov
On 03/01/05 03:14, Douglas Gilbert wrote: - scsi_error.c: scsi_normalize_sense I introduced scsi_normalize_sense() recently, Christoph H. proposed it should be static but Luben Tuikov (aic7xxx maintainer) said he wished to use it in the future. Hence it was left global. Hi guys, I think the idea

RE: [2.6 patch] SCSI: possible cleanups

2005-03-01 Thread Salyzyn, Mark
Christoph Hellwig writes: >> - scsi_scan.c: scsi_rescan_device >aacraid was going to use that one, Mark, any chance to get a patch anytime soon? >> - scsi_scan.c: scsi_scan_single_target >as mentioned above we'll need this one soon. Yup, we use both of them in our branch of the driver. I submi

Re: [2.6 patch] SCSI: possible cleanups

2005-03-01 Thread Douglas Gilbert
Adrian Bunk wrote: Before I'm getting flamed to death: Adrian, I have a few comments below. This patch contains possible cleanups. If parts of this patch conflict with pending changes these parts of my patch have to be dropped. This patch contains the following possible cleanups: - make needlessl

Re: [2.6 patch] SCSI: possible cleanups

2005-02-28 Thread Christoph Hellwig
On Tue, Mar 01, 2005 at 12:01:55AM +0100, Adrian Bunk wrote: > On Mon, Feb 28, 2005 at 10:25:09PM +, Christoph Hellwig wrote: > >... > > > - constants.c: scsi_print_hostbyte > > > - constants.c: scsi_print_driverbyte > > > > these we'll probably keep for now. > >... > > keep = #if 0 ? In

Re: [2.6 patch] SCSI: possible cleanups

2005-02-28 Thread Adrian Bunk
On Mon, Feb 28, 2005 at 10:25:09PM +, Christoph Hellwig wrote: >... > > - constants.c: scsi_print_hostbyte > > - constants.c: scsi_print_driverbyte > > these we'll probably keep for now. >... keep = #if 0 ? cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly ou

Re: [2.6 patch] SCSI: possible cleanups

2005-02-28 Thread Christoph Hellwig
On Mon, Feb 28, 2005 at 10:31:59PM +0100, Adrian Bunk wrote: > Before I'm getting flamed to death: > This patch contains possible cleanups. If parts of this patch conflict > with pending changes these parts of my patch have to be dropped. > > This patch contains the following possible cleanups: >