Re: PATCH [4/5] qla2xxx: cleanup DMA mappings...

2005-04-15 Thread Andrew Vasquez
On Wed, 13 Apr 2005, Christoph Hellwig wrote: > > + struct page *page; > > + unsigned long offset; > > + > > + page = virt_to_page(cmd->request_buffer); > > + offset = ((unsigned long)cmd->request_buffer & ~PAGE_MASK); > > + req_dma = pci_map

Re: PATCH [4/5] qla2xxx: cleanup DMA mappings...

2005-04-13 Thread Christoph Hellwig
> + struct page *page; > + unsigned long offset; > + > + page = virt_to_page(cmd->request_buffer); > + offset = ((unsigned long)cmd->request_buffer & ~PAGE_MASK); > + req_dma = pci_map_page(ha->pdev, page, offset, > +

PATCH [4/5] qla2xxx: cleanup DMA mappings...

2005-04-13 Thread Andrew Vasquez
Don't use cmd->request->nr_hw_segments as it may not be initialized (SG_IO in particular bypasses anything that initializes this and just uses scsi_do_req to insert a scsi_request directly on the head of the queue) and a bogus value here can trip up the checks to make sure that the number