Re: PATCH: atp870u DMA mask

2005-03-11 Thread Alan Cox
On Gwe, 2005-03-11 at 14:40, Arjan van de Ven wrote: > > -if (!pci_set_dma_mask(pdev, 0xFFUL)) { > > +if (!pci_set_dma_mask(pdev, 0xUL)) { > isn't it still an F short? > And... why not use the DMA_32_BIT or whatever define.. it's there for > exactly this reason :) No it

Re: PATCH: atp870u DMA mask

2005-03-11 Thread Arjan van de Ven
On Fri, 2005-03-11 at 14:17 +, Alan Cox wrote: > Noted by James Bottomley > > Signed-off-by: Alan Cox <[EMAIL PROTECTED]> > > --- drivers/scsi/atp870u.c.old2005-03-11 14:14:53.015465656 + > +++ drivers/scsi/atp870u.c2005-03-11 14:15:24.950610776 + > @@ -2634,7 +2634,7 @@ >

PATCH: atp870u DMA mask

2005-03-11 Thread Alan Cox
Noted by James Bottomley Signed-off-by: Alan Cox <[EMAIL PROTECTED]> --- drivers/scsi/atp870u.c.old 2005-03-11 14:14:53.015465656 + +++ drivers/scsi/atp870u.c 2005-03-11 14:15:24.950610776 + @@ -2634,7 +2634,7 @@ if (pci_enable_device(pdev)) return -EIO; -