Re: [patch 17/29] Fix the reproducible oops in scsi

2007-03-10 Thread Andrew Morton
> On Wed, 7 Mar 2007 23:39:52 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > > On Tue, 06 Mar 2007 16:25:09 -0600 James Bottomley <[EMAIL PROTECTED]> > > wrote: > > On Tue, 2007-03-06 at 13:46 -0800, Andrew Morton wrote: > > > On Tue, 06 Mar 2007 08:53:20 -0500 > > > James Smart <[EMAIL PROTECTE

Re: [patch 17/29] Fix the reproducible oops in scsi

2007-03-07 Thread Andrew Morton
> On Tue, 06 Mar 2007 16:25:09 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > On Tue, 2007-03-06 at 13:46 -0800, Andrew Morton wrote: > > On Tue, 06 Mar 2007 08:53:20 -0500 > > James Smart <[EMAIL PROTECTED]> wrote: > > > > > FYI - the *real* patch was posted to linux-scsi, and is under test a

[patch 17/29] Fix the reproducible oops in scsi

2007-03-06 Thread akpm
EMAIL PROTECTED]> --- drivers/scsi/scsi.c |2 ++ 1 file changed, 2 insertions(+) diff -puN drivers/scsi/scsi.c~fix-the-reproducible-oops-in-scsi drivers/scsi/scsi.c --- a/drivers/scsi/scsi.c~fix-the-reproducible-oops-in-scsi +++ a/drivers/scsi/scsi.c @@ -937,6 +937,8 @@ struct scsi_device *__

Re: [patch 19/30] Fix the reproducible oops in scsi

2007-02-16 Thread James Smart
7;re actually using a partially torn down sdev that, if the refcounts ever decremented, would be zapped - and you would be in a bunch of trouble. Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/scsi.c |2 ++ 1 file changed, 2 insertions(+) diff -puN drivers/scsi/s

[patch 19/30] Fix the reproducible oops in scsi

2007-02-16 Thread akpm
EMAIL PROTECTED]> --- drivers/scsi/scsi.c |2 ++ 1 file changed, 2 insertions(+) diff -puN drivers/scsi/scsi.c~fix-the-reproducible-oops-in-scsi drivers/scsi/scsi.c --- a/drivers/scsi/scsi.c~fix-the-reproducible-oops-in-scsi +++ a/drivers/scsi/scsi.c @@ -937,6 +937,8 @@ struct scsi_device *__

Re: [patch 25/33] Fix the reproducible oops in scsi

2007-02-06 Thread James Smart
Hannes and I will be fostering discussion at the upcoming IO summit to discuss options. -- james s Andrew Morton wrote: On Tue, 06 Feb 2007 09:22:06 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: On Mon, 2007-02-05 at 16:38 -0800, [EMAIL PROTECTED] wrote: From: OGAWA Hirofumi <[EMAIL PROTE

Re: [patch 25/33] Fix the reproducible oops in scsi

2007-02-06 Thread Andrew Morton
On Tue, 06 Feb 2007 09:22:06 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > On Mon, 2007-02-05 at 16:38 -0800, [EMAIL PROTECTED] wrote: > > From: OGAWA Hirofumi <[EMAIL PROTECTED]> > > > > I got the oops after some hotplug events. And the similar oops can > > reproduce by the following step.

Re: [patch 25/33] Fix the reproducible oops in scsi

2007-02-06 Thread James Bottomley
On Mon, 2007-02-05 at 16:38 -0800, [EMAIL PROTECTED] wrote: > From: OGAWA Hirofumi <[EMAIL PROTECTED]> > > I got the oops after some hotplug events. And the similar oops can > reproduce by the following step. James Smart already pointed out that this fix isn't valid ... it's a bandaid that doesn'

[patch 25/33] Fix the reproducible oops in scsi

2007-02-05 Thread akpm
EMAIL PROTECTED]> --- drivers/scsi/scsi.c |2 ++ 1 file changed, 2 insertions(+) diff -puN drivers/scsi/scsi.c~fix-the-reproducible-oops-in-scsi drivers/scsi/scsi.c --- a/drivers/scsi/scsi.c~fix-the-reproducible-oops-in-scsi +++ a/drivers/scsi/scsi.c @@ -938,6 +938,8 @@ struct scsi_device *__

Re: Fix the reproducible oops in scsi

2007-01-10 Thread OGAWA Hirofumi
James Smart <[EMAIL PROTECTED]> writes: > I don't believe this is a valid fix. This is yet another case > of the reuse-after-free issues on sdevs. The real issue is the > deleted sdev isn't truly getting deleted due to references, and > we're deadlocked trying to allocate a new one while the old o

Re: Fix the reproducible oops in scsi

2007-01-10 Thread James Smart
I don't believe this is a valid fix. This is yet another case of the reuse-after-free issues on sdevs. The real issue is the deleted sdev isn't truly getting deleted due to references, and we're deadlocked trying to allocate a new one while the old one is outstanding. This fix just jumps over thin

Fix the reproducible oops in scsi

2007-01-09 Thread OGAWA Hirofumi
I got the oops after some hotplug events. And the similar oops can reproduce by the following step. plug usb-storage (e.g. scsi_host of usb is "host5", and device is sde) # mount /dev/sde1 /mnt # echo 1 > /sys/block/sde/device/delete # echo - - - > /sys/class/scsi_host/host5/scan #